linux-kernel - Re: [PATCH v2] x86/resctrl: Annotate get_mem_config functions as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240917133520.GA2360164@thelio-3990X>
Date: Tue, 17 Sep 2024 06:35:20 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Reinette Chatre <reinette.chatre@...el.com>
Cc: Fenghua Yu <fenghua.yu@...el.com>, x86@...nel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	patches@...ts.linux.dev
Subject: Re: [PATCH v2] x86/resctrl: Annotate get_mem_config functions as
 __init

Hi Reinette,

On Mon, Sep 16, 2024 at 02:42:09PM -0700, Reinette Chatre wrote:
> Just one nit in the subject ... this area has the custom to use "()" to
> highlight that the name refers to a function, so rather:
> 
> 	x86/resctrl: Annotate get_mem_config() functions as __init

Thanks, I am aware of this custom since I do it in the commit message
but since get_mem_config() is a function in this file and it is not
exactly touched by this change, it did not really feel appropriate to
add the parentheses there.

I can send a v3 with this fixed if so desired or perhaps whoever is
going to apply this can just do it then?

> On 9/13/24 4:27 PM, Nathan Chancellor wrote:
> > After a recent LLVM change [1] that deduces __cold on functions that
> > only call cold code (such as __init functions), there is a section
> > mismatch warning from __get_mem_config_intel(), which got moved to
> > .text.unlikely. as a result of that optimization:
> > 
> >    WARNING: modpost: vmlinux: section mismatch in reference: __get_mem_config_intel+0x77 (section: .text.unlikely.) -> thread_throttle_mode_init (section: .init.text)
> > 
> > Mark __get_mem_config_intel() as __init as well since it is only called
> > from __init code, which clears up the warning.
> > 
> > While __rdt_get_mem_config_amd() does not exhibit a warning because it
> > does not call any __init code, it is a similar function that is only
> > called from __init code like __get_mem_config_intel(), so mark it __init
> > as well to keep the code symmetrical.
> > 
> > Link: https://github.com/llvm/llvm-project/commit/6b11573b8c5e3d36beee099dbe7347c2a007bf53 [1]
> > Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> > ---
> 
> Thank you very much.
> With subject adjusted:
> 
> | Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Thanks a lot for the review!

Cheers,
Nathan