linux-kernel - Re: [PATCH v2 0/7] linux-kbuild: fix: process configs set to "y"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATbgLrU07dZe+30jzUuP-A1KRfPY8=E2hP9W-Rvzsfg8Q@mail.gmail.com>
Date: Tue, 17 Sep 2024 23:45:36 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: David Hunter <david.hunter.linux@...il.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	shuah@...nel.org, javier.carrasco.cruz@...il.com, 
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v2 0/7] linux-kbuild: fix: process configs set to "y"

(+CC: Steven Rostedt, the author of this script)




On Mon, Sep 16, 2024 at 11:31 PM David Hunter
<david.hunter.linux@...il.com> wrote:
>
> An assumption made in this script is that the config options do not need
> to be processed because they will simply be in the new config file. This
> assumption is incorrect.
>
> Process the config entries set to "y" because those config entries might
> have dependencies set to "m". If a config entry is set to "m" and is not
> loaded directly into the machine, the script will currently turn off
> that config entry; however, if that turned off config entry is a
> dependency for a "y" option. that means the config entry set to "y"
> will also be turned off later when the conf executive file is called.
>
> Here is a model of the problem (arrows show dependency):
>
> Original config file
> Config_1 (m) <-- Config_2 (y)
>
> Config_1 is not loaded in this example, so it is turned off.
> After scripts/kconfig/streamline_config.pl, but before scripts/kconfig/conf
> Config_1 (n) <-- Config_2 (y)
>
> After  scripts/kconfig/conf
> Config_1 (n) <-- Config_2 (n)
>
>
> It should also be noted that any module in the dependency chain will
> also be turned off, even if that module is loaded directly onto the
> computer. Here is an example:
>
> Original config file
> Config_1 (m) <-- Config_2 (y) <-- Config_3 (m)
>
> Config_3 will be loaded in this example.
> After scripts/kconfig/streamline_config.pl, but before scripts/kconfig/conf
> Config_1 (n) <-- Config_2 (y) <-- Config_3 (m)
>
> After scripts/kconfig/conf
> Config_1 (n) <-- Config_2 (n) <-- Config_3 (n)
>
>
> I discovered this problem when I ran "make localmodconfig" on a generic
> Ubuntu config file. Many hardware devices were not recognized once the
> kernel was installed and booted. Another way to reproduced the error I
> had is to run "make localmodconfig" twice. The standard error might display
> warnings that certain modules should be selected but no config files are
> turned on that select that module.
>
> With the changes in this series patch, all modules are loaded properly
> and all of the hardware is loaded when the kernel is installed and
> booted.
>
>
> David Hunter (7):
>   linux-kbuild: fix: config option can be bool
>   linux-kbuild: fix: missing variable operator
>   linux-kbuild: fix: ensure all defaults are tracked
>   linux-kbuild: fix: ensure selected configs were turned on in original
>   linux-kbuild: fix: implement choice for kconfigs
>   linux-kbuild: fix: configs with defaults do not need a prompt
>   linux-kbuild: fix: process config options set to "y"
>
> ---
> V2:
>         - Put in subject.
> V1:
>         - https://lore.kernel.org/all/20240913171205.22126-1-david.hunter.linux@gmail.com/
>
> ---
>  scripts/kconfig/streamline_config.pl | 77 ++++++++++++++++++++++++----
>  1 file changed, 66 insertions(+), 11 deletions(-)
>
>
>
>


--
Best Regards
Masahiro Yamada