linux-kernel - Re: [PATCH] x86/ftrace: Include <asm/ptrace.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240917141736.e24ca6004730435676031997@kernel.org>
Date: Tue, 17 Sep 2024 14:17:36 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Sami Tolvanen <samitolvanen@...gle.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Mark Rutland
 <mark.rutland@....com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
 <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
 <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin"
 <hpa@...or.com>, Masahiro Yamada <masahiroy@...nel.org>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/ftrace: Include <asm/ptrace.h>

On Mon, 16 Sep 2024 22:15:57 +0000
Sami Tolvanen <samitolvanen@...gle.com> wrote:

> <asm/ftrace.h> uses struct pt_regs in several places. Include
> <asm/ptrace.h> to ensure it's visible. This is needed to make sure
> object files that only include <asm/asm-prototypes.h> compile.

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks!

> 
> Suggested-by: Masahiro Yamada <masahiroy@...nel.org>
> Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com>
> ---
>  arch/x86/include/asm/ftrace.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
> index 0152a81d9b4a..b4d719de2c84 100644
> --- a/arch/x86/include/asm/ftrace.h
> +++ b/arch/x86/include/asm/ftrace.h
> @@ -2,6 +2,8 @@
>  #ifndef _ASM_X86_FTRACE_H
>  #define _ASM_X86_FTRACE_H
>  
> +#include <asm/ptrace.h>
> +
>  #ifdef CONFIG_FUNCTION_TRACER
>  #ifndef CC_USING_FENTRY
>  # error Compiler does not support fentry?
> 
> base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
> -- 
> 2.46.0.662.g92d0881bb0-goog
> 

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>