linux-kernel - Re: [PATCH] usb: use mutex_lock in iowarrior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64dfb120-3a95-44dd-a50c-c4818baeb833@suse.com>
Date: Tue, 17 Sep 2024 18:02:42 +0200
From: Oliver Neukum <oneukum@...e.com>
To: Jeongjun Park <aha310510@...il.com>, oneukum@...e.com
Cc: colin.i.king@...il.com, gregkh@...uxfoundation.org,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: use mutex_lock in iowarrior_read()

On 17.09.24 17:41, Jeongjun Park wrote:

Hi,

comments in line.
  
> ---
>   drivers/usb/misc/iowarrior.c | 46 ++++++++++++++++++++++++++++--------
>   1 file changed, 36 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c
> index 6d28467ce352..dbf0ed04f7c3 100644
> --- a/drivers/usb/misc/iowarrior.c
> +++ b/drivers/usb/misc/iowarrior.c
> @@ -277,28 +277,45 @@ static ssize_t iowarrior_read(struct file *file, char __user *buffer,
>   	struct iowarrior *dev;
>   	int read_idx;
>   	int offset;
> +	int retval = 0;

Initialization is useless.

The rest is fine.

	Regards
		Oliver