linux-kernel - Re: [PATCH v2] x86/resctrl: Annotate get_mem_config functions as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240917160413.GA2865863@thelio-3990X>
Date: Tue, 17 Sep 2024 09:04:13 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Reinette Chatre <reinette.chatre@...el.com>
Cc: Fenghua Yu <fenghua.yu@...el.com>, x86@...nel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	patches@...ts.linux.dev
Subject: Re: [PATCH v2] x86/resctrl: Annotate get_mem_config functions as
 __init

On Tue, Sep 17, 2024 at 08:14:17AM -0700, Reinette Chatre wrote:
> Hi Nathan,
> 
> On 9/17/24 6:35 AM, Nathan Chancellor wrote:
> > Hi Reinette,
> > 
> > On Mon, Sep 16, 2024 at 02:42:09PM -0700, Reinette Chatre wrote:
> > > Just one nit in the subject ... this area has the custom to use "()" to
> > > highlight that the name refers to a function, so rather:
> > > 
> > > 	x86/resctrl: Annotate get_mem_config() functions as __init
> > 
> > Thanks, I am aware of this custom since I do it in the commit message
> > but since get_mem_config() is a function in this file and it is not
> > exactly touched by this change, it did not really feel appropriate to
> > add the parentheses there.
> 
> hmmm ... I understand that () is used to highlight that the text is
> referring to a function independent from how the function is impacted
> by the change.
> 
> > 
> > I can send a v3 with this fixed if so desired or perhaps whoever is
> > going to apply this can just do it then?
> 
> Could you please send v3? That will make its inclusion smoother (pending
> any other feedback from next level maintainers).

Alright sure, done: https://lore.kernel.org/20240917-x86-restctrl-get_mem_config_intel-init-v3-1-10d521256284@kernel.org/

Cheers,
Nathan