linux-kernel - Re: [PATCH v2] usb: dwc3: core: Stop processing of pending events if controller is halted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da717b2e-e8dc-461f-bef7-d3d9e5df3632@samsung.com>
Date: Tue, 17 Sep 2024 21:52:00 +0530
From: Selvarasu Ganesan <selvarasu.g@...sung.com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, Thinh Nguyen
	<Thinh.Nguyen@...opsys.com>
Cc: "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jh0801.jung@...sung.com" <jh0801.jung@...sung.com>, "dh10.jung@...sung.com"
	<dh10.jung@...sung.com>, "naushad@...sung.com" <naushad@...sung.com>,
	"akash.m5@...sung.com" <akash.m5@...sung.com>, "rc93.raju@...sung.com"
	<rc93.raju@...sung.com>, "taehyun.cho@...sung.com"
	<taehyun.cho@...sung.com>, "hongpooh.kim@...sung.com"
	<hongpooh.kim@...sung.com>, "eomji.oh@...sung.com" <eomji.oh@...sung.com>,
	"shijie.cai@...sung.com" <shijie.cai@...sung.com>, stable
	<stable@...nel.org>
Subject: Re: [PATCH v2] usb: dwc3: core: Stop processing of pending events
 if controller is halted


On 9/17/2024 12:38 PM, gregkh@...uxfoundation.org wrote:
> On Tue, Sep 17, 2024 at 05:47:05AM +0000, Thinh Nguyen wrote:
>> On Tue, Sep 17, 2024, gregkh@...uxfoundation.org wrote:
>>> On Mon, Sep 16, 2024 at 11:00:30PM +0000, Thinh Nguyen wrote:
>>>> On Tue, Sep 17, 2024, Selvarasu Ganesan wrote:
>>>>> This commit addresses an issue where events were being processed when
>>>>> the controller was in a halted state. To fix this issue by stop
>>>>> processing the events as the event count was considered stale or
>>>>> invalid when the controller was halted.
>>>>>
>>>>> Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
>>>>> Cc: stable <stable@...nel.org>
>>>> Checkpatch doesn't like that format. Fix the Cc stable tag to below:
>>>>
>>>> Cc: stable@...nel.org
>>> What?  Why?  That should be fine, exactly what is the warning that this
>>> gives?  That should be fine, as it's what my scripts put into patches
>>> that I create :)
>>>
>> This is what checkpatch complains:
>>
>> WARNING:BAD_STABLE_ADDRESS_STYLE: Invalid email format for stable: 'stable <stable@...nel.org>', prefer 'stable@...nel.org'
>> #23:
>> Cc: stable <stable@...nel.org>
>>
>> total: 0 errors, 1 warnings, 0 checks, 72 lines checked
> Ugh, that's wrong, whatever you want to do here is fine.
>
> Someone should send a patch for checkpatch...
>
> thanks,
>
> greg k-h

Hi Greg,

However I already posted new version with address a typo mistake as 
well. Kindly review the same.

https://lore.kernel.org/lkml/20240916231813.206-1-selvarasu.g@samsung.com/

Thanks,
Selva
>