linux-kernel - Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54301358-1549-4080-aec5-6de8939257ee@yandex.ru>
Date: Tue, 17 Sep 2024 20:01:00 +0300
From: Dmitry Antipov <dmantipov@...dex.ru>
To: Alper Nebi Yasak <alpernebiyasak@...il.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 David Lin <yu-hao.lin@....com>, Brian Norris <briannorris@...omium.org>,
 Kalle Valo <kvalo@...nel.org>, Francesco Dolcini <francesco@...cini.it>,
 Sascha Hauer <s.hauer@...gutronix.de>, Kees Cook <kees@...nel.org>,
 "Gustavo A . R . Silva" <gustavoars@...nel.org>,
 Johannes Berg <johannes.berg@...el.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning
 in mwifiex_config_scan()

On 9/17/24 7:30 PM, Andy Shevchenko wrote:

> This hunk has to be carefully checked by wireless people. I'm not sure
> that we need  + 1 here.

Well, +1 looks redundant here indeed.

And if you touch this anyway, please also consider '__counted_by(max_ssid_length)'
for 'ssid' (and test your kernel with CONFIG_KASAN enabled of course).

Dmitry