[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZunCysUTSfQU1ylg@skv.local>
Date: Tue, 17 Sep 2024 20:56:26 +0300
From: Andrey Skvortsov <andrej.skvortzov@...il.com>
To: Dragan Simic <dsimic@...jaro.org>
Cc: Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Ondřej Jirman <megi@....cz>
Subject: Re: [PATCH] arm64: dts: sun50i-a64-pinephone: Add mount matrix for
accelerometer
Hi, Dragan,
On 24-09-16 23:08, Dragan Simic wrote:
> Hello Andrey,
>
> On 2024-09-16 22:45, Andrey Skvortsov wrote:
> > From: Ondřej Jirman <megi@....cz>
> >
> > accelerometer is mounted the way x and z-axis are invereted, x and y
> > axis have to be spawed to match device orientation.
> > The mount matrix is based on PCB drawing and was tested on the device.
>
> This commit summary should be copyedited for grammar and style. If
> you want, I can provide a copyedited version?
It would be helpful to avoid further grammar/style problems in the
commit message. Thanks in advance.
>
> > Signed-off-by: Ondrej Jirman <megi@....cz>
> > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@...il.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > index bc6af17e9267a..1da7506c38cd0 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > @@ -229,6 +229,9 @@ accelerometer@68 {
> > interrupts = <7 5 IRQ_TYPE_EDGE_RISING>; /* PH5 */
> > vdd-supply = <®_dldo1>;
> > vddio-supply = <®_dldo1>;
> > + mount-matrix = "0", "1", "0",
> > + "-1", "0", "0",
> > + "0", "0", "-1";
> > };
> > };
--
Best regards,
Andrey Skvortsov
Powered by blists - more mailing lists