linux-kernel - Re: [PATCH] HID: logitech-hidpp: Remove feature_type from hidpp_root_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44a94753410c3a96e6144f2ab19876f039d80707.camel@hadess.net>
Date: Tue, 17 Sep 2024 20:38:36 +0200
From: Bastien Nocera <hadess@...ess.net>
To: linux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>, Benjamin
 Tissoires <benjamin.tissoires@...hat.com>, "Peter F . Patel-Schneider"
 <pfpschneider@...il.com>,  Filipe Laíns
 <lains@...eup.net>
Subject: Re: [PATCH] HID: logitech-hidpp: Remove feature_type from
 hidpp_root_get_feature()

On Mon, 2024-09-16 at 13:55 +0200, Bastien Nocera wrote:
> Nobody uses that variable after it gets assigned, so this saves us from
> having to declare it in the first place.
> 
> Signed-off-by: Bastien Nocera <hadess@...ess.net>

I realised after sending the patch, as I was finishing up work on
enabling the Litra Beam light in user-space rather than the kernel[1],
that I didn't even compile-test this patch.

It's done now, and the patch compiles without warnings.

Enjoy Plumbers for those who celebrate.

Cheers

[1]: https://github.com/cvuchener/hidpp/pull/34