linux-kernel - Re: [PATCH] netfs, cifs: Fix mtime/ctime update for mmapped writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mu3TBeMugfWddNYSpPZiYe8Hhv7DYY52rsMb-Zs8BMv4g@mail.gmail.com>
Date: Tue, 17 Sep 2024 16:24:26 -0500
From: Steve French <smfrench@...il.com>
To: Paulo Alcantara <pc@...guebit.com>
Cc: David Howells <dhowells@...hat.com>, Steve French <sfrench@...ba.org>, 
	Christian Brauner <brauner@...nel.org>, kernel test robot <oliver.sang@...el.com>, 
	Jeff Layton <jlayton@...nel.org>, linux-cifs@...r.kernel.org, netfs@...ts.linux.dev, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfs, cifs: Fix mtime/ctime update for mmapped writes

You can also add "Tested-by: Steve French <stfrench@...rosoft.com>"

On Tue, Sep 17, 2024 at 1:01 PM Paulo Alcantara <pc@...guebit.com> wrote:
>
> David Howells <dhowells@...hat.com> writes:
>
> > The cifs flag CIFS_INO_MODIFIED_ATTR, which indicates that the mtime and
> > ctime need to be written back on close, got taken over by netfs as
> > NETFS_ICTX_MODIFIED_ATTR to avoid the need to call a function pointer to
> > set it.
> >
> > The flag gets set correctly on buffered writes, but doesn't get set by
> > netfs_page_mkwrite(), leading to occasional failures in generic/080 and
> > generic/215.
> >
> > Fix this by setting the flag in netfs_page_mkwrite().
> >
> > Fixes: 73425800ac94 ("netfs, cifs: Move CIFS_INO_MODIFIED_ATTR to netfs_inode")
> > Reported-by: kernel test robot <oliver.sang@...el.com>
> > Closes: https://lore.kernel.org/oe-lkp/202409161629.98887b2-oliver.sang@intel.com
> > Signed-off-by: David Howells <dhowells@...hat.com>
> > cc: Jeff Layton <jlayton@...nel.org>
> > cc: Steve French <sfrench@...ba.org>
> > cc: Paulo Alcantara <pc@...guebit.com>
> > cc: linux-cifs@...r.kernel.org
> > cc: netfs@...ts.linux.dev
> > cc: linux-fsdevel@...r.kernel.org
> > ---
> >  fs/netfs/buffered_write.c |    1 +
> >  1 file changed, 1 insertion(+)
>
> Reviewed-by: Paulo Alcantara (Red Hat) <pc@...guebit.com>
>


-- 
Thanks,

Steve