linux-kernel - Re: [PATCH v2 4/4] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9449091-bd99-46ea-9f76-bbe0ce646c5d@kernel.org>
Date: Wed, 18 Sep 2024 10:13:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrei Stefanescu <andrei.stefanescu@....nxp.com>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chester Lin <chester62515@...il.com>,
 Matthias Brugger <mbrugger@...e.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 NXP S32 Linux Team <s32@....com>
Subject: Re: [PATCH v2 4/4] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO
 driver

On 18/09/2024 09:57, Andrei Stefanescu wrote:
> Hi Krzysztof,
> 
> On 17/09/2024 20:44, Krzysztof Kozlowski wrote:
>> On 13/09/2024 10:29, Andrei Stefanescu wrote:
>>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
>>> ---
>>>  MAINTAINERS | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 10430778c998..e23c4369b6e1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE
>>>  R:	Chester Lin <chester62515@...il.com>
>>>  R:	Matthias Brugger <mbrugger@...e.com>
>>>  R:	Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>
>>> +R: 	Andrei Stefanescu <andrei.stefanescu@....nxp.com>
>>
>> That's another patch where NXP adds silently themself as platform
>> maintainer without explanation. Although here at least existing
>> maintainers are Cced.
>>
>> This looks like some pattern, so maybe clarifications are needed.
>>
>> You wanted to be maintainer of this driver alone, right? So separate entry.
> 
> I would actually want to become a maintainer for the platform. I have
> already added changes to the pinctrl driver and the s32g2.dtsi/s32g3.dtsi files.
> I intend to submit more patches to these files and I would like to review
> changes to them.

That's fine, so please provide some sort of message in the commit,
describing your intention, document the commitment.

> 
> However, if you or any of the existing maintainers consider that I should
> only add myself as a maintainer for the SIUL2 GPIO driver, I can fix this in v3.

I assume you proposed this after consulting them? It is unusual to add
yourself to maintainers without first talking to existing folks...

Best regards,
Krzysztof