linux-kernel - Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Enable interrupt setting for pca9555

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9268240-4c57-4f5c-8ebb-82abb5ce0e3c@kernel.org>
Date: Wed, 18 Sep 2024 10:16:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>,
 "patrick@...cx.xyz" <patrick@...cx.xyz>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 Andrew Jeffery <andrew@...econstruct.com.au>
Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Enable interrupt setting
 for pca9555

On 18/09/2024 05:12, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: Monday, September 16, 2024 4:51 PM
>> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>;
>> patrick@...cx.xyz; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
>> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Joel Stanley
>> <joel@....id.au>; Andrew Jeffery <andrew@...econstruct.com.au>
>> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>;
>> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
>> linux-aspeed@...ts.ozlabs.org; linux-kernel@...r.kernel.org
>> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Enable interrupt setting
>> for pca9555
>>
>>  [External Sender]
>>
>>  [External Sender]
>>
>> On 10/09/2024 10:20, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
>>> I will revise in v2. Thanks!
>>>>> +             interrupt-parent = <&gpio0>;
>>>>> +             interrupts = <98 IRQ_TYPE_LEVEL_LOW>;
>>>>> +             gpio-line-names =
>>>>> +             "P48V_OCP_GPIO1","P48V_OCP_GPIO2",
>>>>
>>>> Nothing improved here. I already commented about above and this.
>>>> Implement feedback for all your patches, not only one.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>> Sorry about that.
>>> I saw you say "Broken alignment" in v15 patch.
>>> Would like to ask if the following format meets your expectations?
>>> +                     gpio-line-names =
>>> +                             "P48V_OCP_GPIO1",
>> "P48V_OCP_GPIO2",
>>> +                             "P48V_OCP_GPIO3",
>>> + "FAN_BOARD_0_REVISION_0_R",
>>
>> Please read DTS coding style before posting next version of the patch (or any
>> patch for DTS). This is still not aligned. There is (almost) never a blank line
>> after '='.
>>
>> Best regards,
>> Krzysztof
> Hi Krzysztof,
> After checking the DTS coding style, I found the "Indentation" section mentioned that:
> "For arrays spanning across lines, it is preferred to align the continued entries with opening < from the first line."
> 
> Should I align the code with following format? (No blank line after = and use two space to align the ")
> Or would like to ask could you help to provide the dts file that I can follow?

Sure, e.g. qcom/sm8650.dtsi, line 765 or line 796.

Or arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi and
gpio-line-names.

Best regards,
Krzysztof