linux-kernel - Re: [lvc-patches] [PATCH] V4L/DVB (13661): rj54n1cb0c: possible integer overflow fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07673b5f-eb7d-167b-d523-230f725e0d11@omp.ru>
Date: Wed, 18 Sep 2024 12:05:01 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Aleksandr Burakov <a.burakov@...alinux.ru>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Guennadi Liakhovetski <g.liakhovetski@....de>
CC: <lvc-project@...uxtesting.org>, <linux-kernel@...r.kernel.org>,
	<lvc-patches@...uxtesting.org>, <linux-media@...r.kernel.org>
Subject: Re: [lvc-patches] [PATCH] V4L/DVB (13661): rj54n1cb0c: possible
 integer overflow fix

On 9/17/24 17:04, Aleksandr Burakov wrote:

> An integer overflow may occur due to arithmetic operation
> (multiplication) between value '314572800' and variable 'resize',
> where the value comes from '12 * RJ54N1_MAX_WIDTH * (1 << 14)' 
> and when 'resize' is equal to 16319.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: a6b5f2008a3d ("V4L/DVB (13661): rj54n1cb0c: Add cropping, auto white balance, restrict sizes, add platform data")
> Signed-off-by: Aleksandr Burakov <a.burakov@...alinux.ru>
> ---
>  drivers/media/i2c/rj54n1cb0c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c
> index a59db10153cd..a612ec1e7157 100644
> --- a/drivers/media/i2c/rj54n1cb0c.c
> +++ b/drivers/media/i2c/rj54n1cb0c.c
> @@ -776,8 +776,8 @@ static int rj54n1_sensor_scale(struct v4l2_subdev *sd, s32 *in_w, s32 *in_h,
>  	}
>  
>  	/* Antiflicker */
> -	peak = 12 * RJ54N1_MAX_WIDTH * (1 << 14) * resize / rj54n1->tgclk_mhz /
> -		10000;
> +	peak = 12 * RJ54N1_MAX_WIDTH * resize / rj54n1->tgclk_mhz / 10000;
> +	peak = peak * (1 << 14);

	peak *= 1 << 14;

[...]

MBR, Sergey