linux-kernel - Re: [PATCH v6 2/7] dt-bindings: PCI: ti,am65: Extend for use with PVU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7qybwyvcjratnxvumvrjk7kjm6aiki27f2lymqaon5e6jljv4w@gqqzygmsprnp>
Date: Wed, 18 Sep 2024 11:11:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jan Kiszka <jan.kiszka@...mens.com>
Cc: Nishanth Menon <nm@...com>, Santosh Shilimkar <ssantosh@...nel.org>, 
	Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org, 
	Siddharth Vadapalli <s-vadapalli@...com>, Bao Cheng Su <baocheng.su@...mens.com>, 
	Hua Qian Li <huaqian.li@...mens.com>, Diogo Ivo <diogo.ivo@...mens.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>, 
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v6 2/7] dt-bindings: PCI: ti,am65: Extend for use with PVU

On Mon, Sep 09, 2024 at 07:03:55PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@...mens.com>
> 
> The PVU on the AM65 SoC is capable of restricting DMA from PCIe devices
> to specific regions of host memory. Add the optional property
> "memory-regions" to point to such regions of memory when PVU is used.
> 
> Since the PVU deals with system physical addresses, utilizing the PVU
> with PCIe devices also requires setting up the VMAP registers to map the
> Requester ID of the PCIe device to the CBA Virtual ID, which in turn is
> mapped to the system physical address. Hence, describe the VMAP
> registers which are optional unless the PVU shall be used for PCIe.
 
> +  memory-region:
> +    maxItems: 1
> +    description: |
> +      phandle to a restricted DMA pool to be used for all devices behind
> +      this controller. The regions should be defined according to
> +      reserved-memory/shared-dma-pool.yaml.
> +      Note that enforcement via the PVU will only be available to
> +      ti,am654-pcie-rc devices.
> +
>  required:
>    - compatible
>    - reg
> @@ -89,6 +102,13 @@ then:
>      - power-domains
>      - msi-map
>      - num-viewport

You could add here schema expressing dependency, e.g.
if:
  properties:
    required:
      - memory-region
then:
  properties:
    reg:
      minItems: 6
    reg-names:
      minItems: 6

If I got your commit msg correctly.

Anyway, it's fine as is.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof