linux-kernel - Re: [PATCH v1 1/1] tee: amdtee: Use %pUl printk() format specifier to print GUIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuqjZswbhLY1iEfr@smile.fi.intel.com>
Date: Wed, 18 Sep 2024 12:54:46 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jerome Forissier <jerome.forissier@...aro.org>
Cc: Rijo Thomas <Rijo-john.Thomas@....com>,
	Devaraj Rangasamy <Devaraj.Rangasamy@....com>,
	op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] tee: amdtee: Use %pUl printk() format specifier
 to print GUIDs

On Tue, Sep 17, 2024 at 09:22:19AM +0200, Jerome Forissier wrote:
> On 9/16/24 11:38, Andy Shevchenko wrote:
> > On Mon, Sep 16, 2024 at 01:38:27PM +0530, Rijo Thomas wrote:
> >> On 9/13/2024 2:59 PM, Andy Shevchenko wrote:
> >>> On Thu, Sep 12, 2024 at 07:50:08AM +0200, Jens Wiklander wrote:
> >>>> On Wed, Sep 11, 2024 at 10:41 PM Andy Shevchenko
> >>>> <andriy.shevchenko@...ux.intel.com> wrote:
> >>>>>
> >>>>> Replace the custom approach with the %pUl printk() format specifier.
> >>>>> No functional change intended.
> >>>
> >>>> Thanks, the patch looks like a nice simplificatrion.
> >>>
> >>> Thank you for the review.
> >>>
> >>>> Rijo, Devaraj, does this work for you?
> >>>
> >>> Yes, please test, because seems others use uuid_t (UUID BE) for TEE,
> >>> but in this driver IIUC it's guid_t (UUID LE).
> >>
> >> No, this does not work for us. I tested this patch, it does not work as expected.
> >>
> >> %pUl gives output in uuid format (%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x).
> >> But, what we need, is a name with the format %08x-%04x-%04x-%02x%02x%02x%02x%02x%02x%02x%02x.
> >>
> >> Endian-ness is not an issue here. uuid generates name with 4 hypens (-).
> >> While, in our TA naming we are using 3 hyphens (-).
> > 
> > Ah, good catch! Can somebody add a comment there to explain that this uses
> > non-standard human-readable representation of GUID/UUID?
> 
> Could this be due to some copying/pasting from the OP-TEE code base which had
> a similar mistake prior to v2.3.0 [1][2][3]?
> 
> [1] https://github.com/OP-TEE/optee_os/blob/2.3.0/CHANGELOG.md?plain=1#L40-L45
> [2] https://github.com/OP-TEE/optee_client/commit/a5b1ffcd26e3
> [3] https://github.com/OP-TEE/optee_client/commit/365657667f89

Interesting... Is somebody going to update this to follow the proper format?
(yes, I understand that the old one has still to be supported)

> > P.S. Thank you for testing!

-- 
With Best Regards,
Andy Shevchenko