linux-kernel - Re: [PATCH 1/1] arm64: dts: qcom: qcs6490-rb3gen2: Add SD Card node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c0f627b-058d-4213-9c2a-5adb2f174c0d@quicinc.com>
Date: Wed, 18 Sep 2024 15:58:04 +0530
From: Sachin Gupta <quic_sachgupt@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_cang@...cinc.com>, <quic_nguyenb@...cinc.com>,
        <quic_bhaskarv@...cinc.com>, <quic_mapa@...cinc.com>,
        <quic_narepall@...cinc.com>, <quic_nitirawa@...cinc.com>,
        <quic_rampraka@...cinc.com>, <quic_sartgarg@...cinc.com>
Subject: Re: [PATCH 1/1] arm64: dts: qcom: qcs6490-rb3gen2: Add SD Card node



On 9/17/2024 7:08 PM, Dmitry Baryshkov wrote:
> On Tue, Sep 17, 2024 at 02:36:30PM GMT, Sachin Gupta wrote:
>> Add SD Card node for Qualcomm qcs6490-rb3gen2 Board.
> 
> Consider adding mmc0 or mmc2 alias for the sdhc_2 node.
> 
Thank you for your input. However, aliases you mentioned already exists 
in the sc7280.dtsi header file.

>> Signed-off-by: Sachin Gupta <quic_sachgupt@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 33 ++++++++++++++++++++
>>   1 file changed, 33 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index 0d45662b8028..5df3167651ca 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -716,9 +716,42 @@
>>   	status = "okay";
>>   };
>>   
>> +&sdc2_clk {
>> +	bias-disable;
>> +	drive-strength = <16>;
>> +};
> 
> Please move all pinctrl-related nodes below the PINCTRL comment.
> 
Will update in next patch.
>> +
>> +&sdc2_cmd {
>> +	bias-pull-up;
>> +	drive-strength = <10>;
>> +};
>> +
>> +&sdc2_data {
>> +	bias-pull-up;
>> +	drive-strength = <10>;
>> +};

Thanks,
Sachin Gupta
>> +
 >>
>>   &tlmm {
>>   	gpio-reserved-ranges = <32 2>, /* ADSP */
>>   			       <48 4>; /* NFC */
>> +
>> +	sd_cd: sd-cd-state {
>> +		pins = "gpio91";
>> +		function = "gpio";
>> +		bias-pull-up;
>> +	};
> 
> There is also a special PINCRTL_related TLMM imstance down the file,
> move it to that node.
> 
Will update in next patch.
>>   };
>>   
>>   &uart5 {
>> -- 
>> 2.17.1
>>
>