lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <7f75cfeb-9fdd-4d07-827b-0c76d6679689@web.de>
Date: Wed, 18 Sep 2024 13:20:10 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-input@...r.kernel.org, Basavaraj Natikar
 <basavaraj.natikar@....com>, Benjamin Tissoires <bentiss@...nel.org>,
 Jiri Kosina <jikos@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] HID: amd_sfh: Use amd_sfh_clear_intr(mp2) call only once in
 sfh_init_work()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 18 Sep 2024 13:11:00 +0200

A amd_sfh_clear_intr(mp2) call was immediately used after a return code
check for a amd_sfh_hid_client_init() call in this function implementation.
Thus use such a function call only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index 0c28ca349bcd..2322555e5181 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -350,13 +350,12 @@ static void sfh_init_work(struct work_struct *work)
 	int rc;

 	rc = amd_sfh_hid_client_init(mp2);
+	amd_sfh_clear_intr(mp2);
 	if (rc) {
-		amd_sfh_clear_intr(mp2);
 		dev_err(&pdev->dev, "amd_sfh_hid_client_init failed err %d\n", rc);
 		return;
 	}

-	amd_sfh_clear_intr(mp2);
 	mp2->init_done = 1;
 }

--
2.46.0


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ