linux-kernel - Re: [PATCH v3 0/7] perf: cs-etm: Coresight decode and disassembly improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24e24324-cb41-4ae7-9584-e97684b12585@os.amperecomputing.com>
Date: Wed, 18 Sep 2024 16:53:06 +0530
From: Ganapatrao Kulkarni <gankulkarni@...amperecomputing.com>
To: James Clark <james.clark@...aro.org>, linux-perf-users@...r.kernel.org,
 coresight@...ts.linaro.org, leo.yan@....com,
 scclevenger@...amperecomputing.com
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>,
 Suzuki K Poulose <suzuki.poulose@....com>, Mike Leach
 <mike.leach@...aro.org>, John Garry <john.g.garry@...cle.com>,
 Will Deacon <will@...nel.org>, Leo Yan <leo.yan@...ux.dev>,
 Ben Gainey <ben.gainey@....com>, Ruidong Tian
 <tianruidong@...ux.alibaba.com>, Benjamin Gray <bgray@...ux.ibm.com>,
 Mathieu Poirier <mathieu.poirier@...aro.org>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 Ilkka Koskinen <ilkka@...amperecomputing.com>
Subject: Re: [PATCH v3 0/7] perf: cs-etm: Coresight decode and disassembly
 improvements


Hi James,

On 16-09-2024 07:27 pm, James Clark wrote:
> A set of changes that came out of the issues reported here [1].
> 
>   * First 2 patches fix a decode bug in Perf and add support for new
>     consistency checks in OpenCSD
>   * The remaining ones make the disassembly script easier to test
>     and use. This also involves adding a new Python binding to
>     Perf to get a config value (perf_config_get())
> 
> [1]: https://lore.kernel.org/linux-arm-kernel/20240719092619.274730-1-gankulkarni@os.amperecomputing.com/
> 

Tried this series with below commands and issue is not seen as reported 
in [1].

record:
timeout 8s ./perf record -e cs_etm// -C 1 -o kcore --kcore dd 
if=/dev/zero of=/dev/null

decode:
./perf script -i ./kcore -s scripts/python/arm-cs-trace-disasm.py -- -d 
objdump -k kcore/kcore_dir/kcore

./perf script -i ./kcore -s scripts/python/arm-cs-trace-disasm.py -F 
cpu,event,ip,addr,sym -- -d objdump -k kcore/kcore_dir/kcore

Feel free to add for 1/7 and 2/7.
Tested-by: Ganapatrao Kulkarni <gankulkarni@...amperecomputing.com>

> Changes since V2:
>    * Check validity of start stop arguments
>    * Make test work if Perf was installed
>    * Document that start and stop time are monotonic clock values
> 
> Changes since V1:
>    * Keep the flush function for discontinuities
>    * Still remove the flush when the buffer fills, but now add
>      cs_etm__end_block() for the end trace. That way we won't drop
>      the last branch stack if the instruction sample period wasn't
>      hit at the very end.
> 
> James Clark (7):
>    perf cs-etm: Don't flush when packet_queue fills up
>    perf cs-etm: Use new OpenCSD consistency checks
>    perf scripting python: Add function to get a config value
>    perf scripts python cs-etm: Update to use argparse
>    perf scripts python cs-etm: Improve arguments
>    perf scripts python cs-etm: Add start and stop arguments
>    perf test: cs-etm: Test Coresight disassembly script
> 
>   .../perf/Documentation/perf-script-python.txt |   2 +-
>   .../scripts/python/Perf-Trace-Util/Context.c  |  11 ++
>   .../scripts/python/arm-cs-trace-disasm.py     | 127 ++++++++++++++----
>   .../tests/shell/test_arm_coresight_disasm.sh  |  65 +++++++++
>   tools/perf/util/config.c                      |  22 +++
>   tools/perf/util/config.h                      |   1 +
>   .../perf/util/cs-etm-decoder/cs-etm-decoder.c |   7 +-
>   tools/perf/util/cs-etm.c                      |  25 +++-
>   8 files changed, 225 insertions(+), 35 deletions(-)
>   create mode 100755 tools/perf/tests/shell/test_arm_coresight_disasm.sh
> 

-- 
Thanks,
Ganapat/GK