[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3ac31595-f596-4960-bba2-0b0b55041193@kernel.org>
Date: Wed, 18 Sep 2024 15:16:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michal Vokáč <michal.vokac@...ft.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Shawn Guo <shawnguo@...nel.org>, Petr Benes <petr.benes@...ft.com>
Cc: Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Herburger <gregor.herburger@...tq-group.com>,
Hiago De Franco <hiago.franco@...adex.com>,
Hugo Villeneuve <hvilleneuve@...onoff.com>,
Joao Paulo Goncalves <joao.goncalves@...adex.com>,
Michael Walle <mwalle@...nel.org>,
Alexander Stein <alexander.stein@...tq-group.com>,
Mathieu Othacehe <m.othacehe@...il.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/4] dt-bindings: usb: Add Diodes Incorporated
PI5USB30213A Type-C Controller
On 17/09/2024 17:10, Michal Vokáč wrote:
> From: Petr Benes <petr.benes@...ft.com>
>
> Diodes Incorporated PI5USB30213A Type-C Controller supports host,
> device, and dual-role mode based on voltage levels detected on CC
> pin. Supports dual differential channel, 2:1 USB 3.0 Mux/Demux,
> USB Type-C specification 1.1.
>
> Signed-off-by: Petr Benes <petr.benes@...ft.com>
> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
> ---
> .../bindings/usb/diodes,pi5usb30213a.yaml | 95 +++++++++++++++++++
> 1 file changed, 95 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml b/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml
> new file mode 100644
> index 000000000000..1cae10724152
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/diodes,pi5usb30213a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PI5USB30213A Type-C port controller
> +
> +description:
> + Diodes Incorporated PI5USB30213A Type-C Controller supports host,
> + device, and dual-role mode based on voltage levels detected on CC
> + pin. Dual differential channel, 2:1 USB 3.0 Mux/Demux, USB Type-C
> + specification 1.1 compliant.
> +
> +maintainers:
> + - Petr Benes <petr.benes@...ft.com>
Please put maintainers before description: block.
> +
> +properties:
> + compatible:
> + enum:
> + - diodes,pi5usb30213a
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + connector:
> + type: object
> + $ref: ../connector/usb-connector.yaml#
Full path, so /schemas/connector/usb-....
> + unevaluatedProperties: false
> + description:
> + The managed USB Type-C connector.
Description should not be needed.
> +
> + properties:
> + compatible:
> + const: usb-c-connector
Drop, not needed.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - connector
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pi5usb30213a: tcpc@d {
typec@d
and drop label
> + compatible = "diodes,pi5usb30213a";
> + reg = <0xd>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_typec>;
> + interrupts-extended = <&gpio1 5 IRQ_TYPE_LEVEL_LOW>;
> + status = "okay";
Drop status
Best regards,
Krzysztof
Powered by blists - more mailing lists