linux-kernel - Re: [PATCH v3 0/4] drm/vkms: Switch all vkms object to DRM managed objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuraD0t6KZTGTFng@localhost.localdomain>
Date: Wed, 18 Sep 2024 15:47:59 +0200
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: airlied@...il.com, arthurgrillo@...eup.net, daniel@...ll.ch,
	dri-devel@...ts.freedesktop.org, hamohammed.sa@...il.com,
	jeremie.dautheribes@...tlin.com, linux-kernel@...r.kernel.org,
	maarten.lankhorst@...ux.intel.com, mairacanal@...eup.net,
	melissa.srw@...il.com, miquel.raynal@...tlin.com,
	mripard@...nel.org, nicolejadeyee@...gle.com,
	rodrigosiqueiramelo@...il.com, seanpaul@...gle.com,
	thomas.petazzoni@...tlin.com, tzimmermann@...e.de
Subject: Re: [PATCH v3 0/4] drm/vkms: Switch all vkms object to DRM managed
 objects

Le 17/09/24 - 18:02, José Expósito a écrit :
> Hi Louis,
> 
> Thanks for making this change even more atomic.
> 
> > To simplify the memory managment this series replace all manual drm 
> > object managment by drm-managed one. This way the VKMS code don't have to 
> > manage it directly and the DRM core will handle the object destruction.
> > 
> > No functional changes are intended in this series. This series depends on 
> > [1] (for writeback connector) and [2] (for cleaning code).
> > 
> > PATCH 1/4: Migrate connector managment to drmm
> > PATCH 2/4: Migrate encoder managment to drmm
> > PATCH 3/4: Migrate connector management to drm
> > PATCH 4/4: Migrate writeback connector management to drm
> > 
> > [1]: https://lore.kernel.org/all/20240906-writeback-drmm-v1-1-01ede328182c@bootlin.com/
> > [2]: https://lore.kernel.org/all/20240906-vkms-remove-index-v1-1-3cfedd8ccb2f@bootlin.com/
> > 
> > Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> 
> The 4 patches:
> Reviewed-by: José Expósito <jose.exposito89@...il.com>

Thanks!
Louis Chauvet
 
> > ---
> > Changes in v3:
> > - As suggested by Maxime, split the managed and the dynamic allocation 
> >   parts in different series
> > - To reduce the diff in this series, extract the "remove crtc index" part, 
> >   see https://lore.kernel.org/all/20240906-vkms-remove-index-v1-1-3cfedd8ccb2f@bootlin.com/
> > - Link to v2: https://lore.kernel.org/r/20240827-google-vkms-managed-v2-0-f41104553aeb@bootlin.com
> > 
> > Changes in v2:
> > - Applied comments from José
> > - Extract the rename vkms_output -> vkms_crtc to avoid useless changes in 
> >   the last commit
> > - Extract the rename to_vkms_crtc_state to
> >   drm_crtc_state_to_vkms_crtc_state to avoid useless changes in last 
> >   commit
> > - Extract the drm_mode_crtc_set_gamma_size result check in its own commit
> > - Rebased on drm-misc/drm-misc-next
> > - Link to v1: https://lore.kernel.org/r/20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com>