[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_MXmSYf0=Lfb5-bsmuK6m2UEgyeVOMp4hjZcpxU82_Z2A@mail.gmail.com>
Date: Wed, 18 Sep 2024 10:03:21 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Rohit Chavan <roheetchavan@...il.com>
Cc: Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>,
Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: Fix unnecessary cast warnings from checkpatch
Acked-by: Alex Deucher <alexander.deucher@....com>
Applied.
Thanks!
On Tue, Sep 17, 2024 at 5:58 PM Rohit Chavan <roheetchavan@...il.com> wrote:
>
> This patch addresses warnings produced by the checkpatch script
> related to unnecessary casts that could potentially hide bugs.
>
> The specific warnings are as follows:
> - Warning at drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c:16
> - Warning at drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c:20
> - Warning at drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c:30
>
> Signed-off-by: Rohit Chavan <roheetchavan@...il.com>
> ---
> drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c
> index 41ecf00ed196..3ab401729f9b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c
> @@ -13,11 +13,11 @@
>
> static bool dml21_allocate_memory(struct dml2_context **dml_ctx)
> {
> - *dml_ctx = (struct dml2_context *)kzalloc(sizeof(struct dml2_context), GFP_KERNEL);
> + *dml_ctx = kzalloc(sizeof(struct dml2_context), GFP_KERNEL);
> if (!(*dml_ctx))
> return false;
>
> - (*dml_ctx)->v21.dml_init.dml2_instance = (struct dml2_instance *)kzalloc(sizeof(struct dml2_instance), GFP_KERNEL);
> + (*dml_ctx)->v21.dml_init.dml2_instance = kzalloc(sizeof(struct dml2_instance), GFP_KERNEL);
> if (!((*dml_ctx)->v21.dml_init.dml2_instance))
> return false;
>
> @@ -27,7 +27,7 @@ static bool dml21_allocate_memory(struct dml2_context **dml_ctx)
> (*dml_ctx)->v21.mode_support.display_config = &(*dml_ctx)->v21.display_config;
> (*dml_ctx)->v21.mode_programming.display_config = (*dml_ctx)->v21.mode_support.display_config;
>
> - (*dml_ctx)->v21.mode_programming.programming = (struct dml2_display_cfg_programming *)kzalloc(sizeof(struct dml2_display_cfg_programming), GFP_KERNEL);
> + (*dml_ctx)->v21.mode_programming.programming = kzalloc(sizeof(struct dml2_display_cfg_programming), GFP_KERNEL);
> if (!((*dml_ctx)->v21.mode_programming.programming))
> return false;
>
> --
> 2.34.1
>
Powered by blists - more mailing lists