linux-kernel - Re: [PATCH] uprobes: Improve the usage of xol slots for better scalability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202409182246.UMkGsMXl-lkp@intel.com>
Date: Wed, 18 Sep 2024 22:41:43 +0800
From: kernel test robot <lkp@...el.com>
To: Liao Chang <liaochang1@...wei.com>, mhiramat@...nel.org,
	oleg@...hat.com, andrii@...nel.org, peterz@...radead.org,
	mingo@...hat.com, acme@...nel.org, namhyung@...nel.org,
	mark.rutland@....com, alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] uprobes: Improve the usage of xol slots for better
 scalability

Hi Liao,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/perf/core]
[cannot apply to perf-tools-next/perf-tools-next perf-tools/perf-tools linus/master acme/perf/core v6.11 next-20240918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liao-Chang/uprobes-Improve-the-usage-of-xol-slots-for-better-scalability/20240918-093915
base:   tip/perf/core
patch link:    https://lore.kernel.org/r/20240918012752.2045713-1-liaochang1%40huawei.com
patch subject: [PATCH] uprobes: Improve the usage of xol slots for better scalability
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240918/202409182246.UMkGsMXl-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240918/202409182246.UMkGsMXl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409182246.UMkGsMXl-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/arm/probes/uprobes/actions-arm.c:10:
>> include/linux/uprobes.h:81:2: error: unknown type name 'refcount_t'
           refcount_t                      slot_ref;
           ^
   1 error generated.


vim +/refcount_t +81 include/linux/uprobes.h

    58	
    59	/*
    60	 * uprobe_task: Metadata of a task while it singlesteps.
    61	 */
    62	struct uprobe_task {
    63		enum uprobe_task_state		state;
    64	
    65		union {
    66			struct {
    67				struct arch_uprobe_task	autask;
    68				unsigned long		vaddr;
    69			};
    70	
    71			struct {
    72				struct callback_head	dup_xol_work;
    73				unsigned long		dup_xol_addr;
    74			};
    75		};
    76	
    77		struct uprobe			*active_uprobe;
    78		unsigned long			xol_vaddr;
    79	
    80		struct list_head		gc;
  > 81		refcount_t			slot_ref;
    82		int				insn_slot;
    83	
    84		struct arch_uprobe              *auprobe;
    85	
    86		struct return_instance		*return_instances;
    87		unsigned int			depth;
    88	};
    89	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki