linux-kernel - Re: [PATCH] driver core: fix async device shutdown hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b5cc9421cfd8dced181335b426646aef2f7309a.camel@redhat.com>
Date: Wed, 18 Sep 2024 17:07:57 -0400
From: Laurence Oberman <loberman@...hat.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stuart hayes
	 <stuart.w.hayes@...il.com>
Cc: linux-kernel@...r.kernel.org, "Rafael J . Wysocki" <rafael@...nel.org>, 
 Martin Belanger <Martin.Belanger@...l.com>, Oliver O'Halloran
 <oohall@...il.com>, Daniel Wagner <dwagner@...e.de>,  Keith Busch
 <kbusch@...nel.org>, Lukas Wunner <lukas@...ner.de>, David Jeffery
 <djeffery@...hat.com>,  Jeremy Allison <jallison@....com>, Jens Axboe
 <axboe@...com>, Christoph Hellwig <hch@....de>, Sagi Grimberg
 <sagi@...mberg.me>, linux-nvme@...ts.infradead.org, Nathan Chancellor
 <nathan@...nel.org>, Jan Kiszka <jan.kiszka@...mens.com>
Subject: Re: [PATCH] driver core: fix async device shutdown hang

On Wed, 2024-09-18 at 08:12 +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 17, 2024 at 07:20:41PM -0500, stuart hayes wrote:
> > 
> > 
> > On 9/17/2024 3:42 PM, Greg Kroah-Hartman wrote:
> > > On Tue, Sep 17, 2024 at 03:15:17PM -0500, Stuart Hayes wrote:
> > > > Modify device_shutdown() so that supplier devices do not wait
> > > > for
> > > > consumer devices to be shut down first when the devlink is sync
> > > > state
> > > > only, since the consumer is not dependent on the supplier in
> > > > this case.
> > > > 
> > > > Without this change, a circular dependency could hang the
> > > > system.
> > > > 
> > > > Signed-off-by: Stuart Hayes <stuart.w.hayes@...il.com>
> > > 
> > > What commit id does this fix?  Should it go to stable?
> > > 
> > > And what driver is causing this problem, is this a regression or
> > > for
> > > something new that just got added to the tree?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > This fixes commit 8064952c65045f05ee2671fe437770e50c151776, in
> > driver-core-next & linux-next... it's problem with code that was
> > just
> > added to the tree (in drivers/base/core.c).  It is not in stable.
> 
> Ah, that wasn't obvious, sorry.
> 
> > Apologies, I should have mentioned that from the start.
> 
> Can you resend this with a "Fixes:" tag in it so I can just take it
> that
> way and not have to edit it by hand?
> 
> thanks,
> 
> greg k-h
> 

FYI 
This patch plus the rest of the original Bundle has been tested 
at Red Hat on a system with 24 nvme devices. 
Improvement was almost 8 times faster to shutdown.

Tested-by: Laurence Oberman <loberman@...hat.com>