linux-kernel - Re: [PATCH] dt-bindings: hwmon: Add adt7462

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240918220553.GA2216504-robh@kernel.org>
Date: Wed, 18 Sep 2024 17:05:53 -0500
From: Rob Herring <robh@...nel.org>
To: Chanh Nguyen <chanh@...amperecomputing.com>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
	OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
	Open Source Submission <patches@...erecomputing.com>,
	Phong Vo <phong@...amperecomputing.com>,
	Thang Nguyen <thang@...amperecomputing.com>,
	Quan Nguyen <quan@...amperecomputing.com>,
	Khanh Pham <khpham@...erecomputing.com>
Subject: Re: [PATCH] dt-bindings: hwmon: Add adt7462

On Wed, Sep 18, 2024 at 10:32:12AM +0000, Chanh Nguyen wrote:
> Add device tree binding and example for adt7462 device.
> 
> Signed-off-by: Chanh Nguyen <chanh@...amperecomputing.com>
> ---
>  .../bindings/hwmon/onnn,adt7462.yaml          | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml b/Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml
> new file mode 100644
> index 000000000000..4a980cca419a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/onnn,adt7462.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/onnn,adt7462.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor ADT7462 Temperature, Voltage Monitor and Fan Controller
> +
> +maintainers:
> +  - Chanh Nguyen <chanh@...amperecomputing.com>
> +
> +description: |
> +  The ADT7462 has temperature monitors, voltage monitors and multiple PWN Fan
> +  controllers.
> +
> +  The ADT7462 supports monitoring and controlling up to four PWM Fan Drive
> +  Outputs and eight TACH Inputs Measures. The ADT7462 supports reading a single
> +  on chip temperature sensor and three remote temperature sensors. There are up
> +  to 13 voltage monitoring inputs, ranging from 12V to 0.9V.
> +
> +  Datasheets:
> +    https://www.onsemi.com/pub/Collateral/ADT7462-D.PDF
> +
> +properties:
> +  compatible:
> +    const: onnn,adt7462
> +
> +  reg:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1

How would this work? 'resets' generally is used for on-chip devices and 
a reset controller. That doesn't exist at the board level. A standalone 
device typically uses a GPIO lines if there's a s/w controlled reset. 
That would be the 'reset-gpios' property.

Rob