linux-kernel - Re: [PATCH 1/1] dmaengine: amd: qdma: Remove using the private get and set dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240918052228.GA31381@lst.de>
Date: Wed, 18 Sep 2024 07:22:28 +0200
From: Christoph Hellwig <hch@....de>
To: Lizhi Hou <lizhi.hou@....com>
Cc: vkol@...nel.org, hch@....de, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org, nishads@....com
Subject: Re: [PATCH 1/1] dmaengine: amd: qdma: Remove using the private get
 and set dma_ops APIs

On Tue, Sep 17, 2024 at 09:17:40AM -0700, Lizhi Hou wrote:
> The get_dma_ops and set_dma_ops APIs were never for driver to use. Remove
> these calls from QDMA driver. Instead, pass the DMA device pointer from the
> qdma_platdata structure.
> 
> Fixes: 73d5fc92a11c ("dmaengine: amd: qdma: Add AMD QDMA driver")
> Signed-off-by: Lizhi Hou <lizhi.hou@....com>

>From the DMA point of view this looks good:

Reviewed-by: Christoph Hellwig <hch@....de>