[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <tencent_24586A9E52F56C5C12E9535AD3F243C98B06@qq.com>
Date: Thu, 19 Sep 2024 07:16:09 +0000
From: Jiawei Ye <jiawei.ye@...mail.com>
To: alex.aring@...il.com,
stefan@...enfreihafen.org,
miquel.raynal@...tlin.com,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
david.girault@...vo.com
Cc: linux-wpan@...r.kernel.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] mac802154: Fix potential RCU dereference issue in mac802154_scan_worker
In the `mac802154_scan_worker` function, the `scan_req->type` field was
accessed after the RCU read-side critical section was unlocked. According
to RCU usage rules, this is illegal and can lead to unpredictable
behavior, such as accessing memory that has been updated or causing
use-after-free issues.
This possible bug was identified using a static analysis tool developed
by myself, specifically designed to detect RCU-related issues.
To address this, the `scan_req->type` value is now stored in a local
variable `scan_req_type` while still within the RCU read-side critical
section. The `scan_req_type` is then used after the RCU lock is released,
ensuring that the type value is safely accessed without violating RCU
rules.
Fixes: e2c3e6f53a7a ("mac802154: Handle active scanning")
Signed-off-by: Jiawei Ye <jiawei.ye@...mail.com>
---
net/mac802154/scan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c
index 1c0eeaa76560..29cd84c9f69c 100644
--- a/net/mac802154/scan.c
+++ b/net/mac802154/scan.c
@@ -180,6 +180,7 @@ void mac802154_scan_worker(struct work_struct *work)
unsigned int scan_duration = 0;
struct wpan_phy *wpan_phy;
u8 scan_req_duration;
+ enum nl802154_scan_types scan_req_type;
u8 page, channel;
int ret;
@@ -210,6 +211,7 @@ void mac802154_scan_worker(struct work_struct *work)
wpan_phy = scan_req->wpan_phy;
scan_req_duration = scan_req->duration;
+ scan_req_type = scan_req->type;
/* Look for the next valid chan */
page = local->scan_page;
@@ -246,7 +248,7 @@ void mac802154_scan_worker(struct work_struct *work)
goto end_scan;
}
- if (scan_req->type == NL802154_SCAN_ACTIVE) {
+ if (scan_req_type == NL802154_SCAN_ACTIVE) {
ret = mac802154_transmit_beacon_req(local, sdata);
if (ret)
dev_err(&sdata->dev->dev,
--
2.34.1
Powered by blists - more mailing lists