| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZuvnhSvVMIGgAVNj@fedora>
Date: Thu, 19 Sep 2024 10:57:41 +0200
From: Baoquan He <bhe@...hat.com>
To: Dave Vasilevsky <dave@...ilevsky.ca>
Cc: akpm@...ux-foundation.org, glaubitz@...sik.fu-berlin.de,
linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org,
mpe@...erman.id.au, kexec@...ts.infradead.org,
linux-kernel@...r.kernel.org, ebiederm@...ssion.com,
Reimar Döffinger <Reimar.Doeffinger@....de>
Subject: Re: [PATCH v2] crash, powerpc: Default to CRASH_DUMP=n on
PPC_BOOK3S_32
On 09/17/24 at 12:37pm, Dave Vasilevsky wrote:
> Fixes boot failures on 6.9 on PPC_BOOK3S_32 machines using
> Open Firmware. On these machines, the kernel refuses to boot
> from non-zero PHYSICAL_START, which occurs when CRASH_DUMP is on.
>
> Since most PPC_BOOK3S_32 machines boot via Open Firmware, it should
> default to off for them. Users booting via some other mechanism
> can still turn it on explicitly.
>
> Does not change the default on any other architectures for the
> time being.
>
> Signed-off-by: Dave Vasilevsky <dave@...ilevsky.ca>
> Reported-by: Reimar Döffinger <Reimar.Doeffinger@....de>
> Closes: https://lists.debian.org/debian-powerpc/2024/07/msg00001.html
> Fixes: 75bc255a7444 ("crash: clean up kdump related config items")
> ---
> arch/arm/Kconfig | 3 +++
> arch/arm64/Kconfig | 3 +++
> arch/loongarch/Kconfig | 3 +++
> arch/mips/Kconfig | 3 +++
> arch/powerpc/Kconfig | 4 ++++
> arch/riscv/Kconfig | 3 +++
> arch/s390/Kconfig | 3 +++
> arch/sh/Kconfig | 3 +++
> arch/x86/Kconfig | 3 +++
> kernel/Kconfig.kexec | 2 +-
> 10 files changed, 29 insertions(+), 1 deletion(-)
Thanks for the effort.
Acked-by: Baoquan He <bhe@...hat.com>
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 0ec034933cae..4cc31467298b 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1598,6 +1598,9 @@ config ATAGS_PROC
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool y
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> config AUTO_ZRELADDR
> bool "Auto calculation of the decompressed kernel image address" if !ARCH_MULTIPLATFORM
> default !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100)
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index ed15b876fa74..8c67b76347d3 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1559,6 +1559,9 @@ config ARCH_DEFAULT_KEXEC_IMAGE_VERIFY_SIG
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool y
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> def_bool CRASH_RESERVE
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 0e3abf7b0bd3..7ba3baee859e 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -600,6 +600,9 @@ config ARCH_SUPPORTS_KEXEC
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool y
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> config ARCH_SELECTS_CRASH_DUMP
> def_bool y
> depends on CRASH_DUMP
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 60077e576935..b547f4304d0c 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2881,6 +2881,9 @@ config ARCH_SUPPORTS_KEXEC
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool y
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> config PHYSICAL_START
> hex "Physical address where the kernel is loaded"
> default "0xffffffff84000000"
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 8a4ee57cd4ef..c04f7bb543cc 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -682,6 +682,10 @@ config RELOCATABLE_TEST
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool PPC64 || PPC_BOOK3S_32 || PPC_85xx || (44x && !SMP)
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + bool
> + default y if !PPC_BOOK3S_32
> +
> config ARCH_SELECTS_CRASH_DUMP
> def_bool y
> depends on CRASH_DUMP
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 86d1f1cea571..341ef759870a 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -882,6 +882,9 @@ config ARCH_SUPPORTS_KEXEC_PURGATORY
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool y
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> def_bool CRASH_RESERVE
>
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index c60e699e99f5..fff371b89e41 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -275,6 +275,9 @@ config ARCH_SUPPORTS_CRASH_DUMP
> This option also enables s390 zfcpdump.
> See also <file:Documentation/arch/s390/zfcpdump.rst>
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> menu "Processor type and features"
>
> config HAVE_MARCH_Z10_FEATURES
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index e9103998cca9..04ff5fb9242e 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -550,6 +550,9 @@ config ARCH_SUPPORTS_KEXEC
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool BROKEN_ON_SMP
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> config ARCH_SUPPORTS_KEXEC_JUMP
> def_bool y
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index d1fe732979d4..7f39db779574 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2092,6 +2092,9 @@ config ARCH_SUPPORTS_KEXEC_JUMP
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool X86_64 || (X86_32 && HIGHMEM)
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool y
> +
> config ARCH_SUPPORTS_CRASH_HOTPLUG
> def_bool y
>
> diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec
> index 6c34e63c88ff..4d111f871951 100644
> --- a/kernel/Kconfig.kexec
> +++ b/kernel/Kconfig.kexec
> @@ -97,7 +97,7 @@ config KEXEC_JUMP
>
> config CRASH_DUMP
> bool "kernel crash dumps"
> - default y
> + default ARCH_DEFAULT_CRASH_DUMP
> depends on ARCH_SUPPORTS_CRASH_DUMP
> depends on KEXEC_CORE
> select VMCORE_INFO
> --
> 2.43.0
>
Powered by blists - more mailing lists