linux-kernel - Re: [PATCH 1/2] dt-bindings: watchdog: airoha: document watchdog for Airoha EN7581

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66ec1ba3.050a0220.2c6214.5dd4@mx.google.com>
Date: Thu, 19 Sep 2024 14:39:59 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-watchdog@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lorenzo Bianconi <lorenzo@...nel.org>, upstream@...oha.com
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: airoha: document watchdog for
 Airoha EN7581

On Thu, Sep 19, 2024 at 02:35:02PM +0200, Krzysztof Kozlowski wrote:
> On 19/09/2024 14:26, Christian Marangi wrote:
> > Document watchdog for Airoha EN7581. This SoC implement a simple
> > watchdog that supports a max timeout of 28 seconds.
> > 
> > The watchdog ticks on half the BUS clock and require the BUS frequency
> > to be provided.
> 
> Clock provider should implement clk_get_rate()...
>

The BUS clock is internal and not exposed to the system hence
clk_get_rate is not possible saddly.

> > 
> 
> ...
> 
> > +maintainers:
> > +  - Christian Marangi <ansuelsmth@...il.com>
> > +
> > +allOf:
> > +  - $ref: watchdog.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: airoha,en7581-wdt
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clock-frequency:
> > +    description: BUS frequency in Hz (timer ticks at half the BUS freq)
> > +    const: 300000000
> 
> Which bus frequency? Aren't you missing here clock input?

I'm putting here property to describe the internal clock to what the
watchdog is attached. Should I drop this and just hardcode it
internally to the driver or maybe declare the clock to be 150000000
directly?

Tick frequency is already not well defined so I tought it was a good
idea to describe it in DT.

-- 
	Ansuel