linux-kernel - Re: [PATCH 0/2] drm/mediatek: Adjustments for mtk_gem_prime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff80024a-90b2-4a19-b827-23be69352f78@collabora.com>
Date: Thu, 19 Sep 2024 15:12:33 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Markus Elfring <Markus.Elfring@....de>,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 dri-devel@...ts.freedesktop.org, Alexandre Mergnat <amergnat@...libre.com>,
 Chen-Yu Tsai <wenst@...omium.org>, Chun-Kuang Hu <chunkuang.hu@...nel.org>,
 David Airlie <airlied@...il.com>, Matthias Brugger <matthias.bgg@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Simona Vetter <simona@...ll.ch>,
 Sui Jingfeng <suijingfeng@...ngson.cn>,
 Thomas Zimmermann <tzimmermann@...e.de>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] drm/mediatek: Adjustments for mtk_gem_prime_vmap()

Il 17/09/24 19:34, Markus Elfring ha scritto:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 17 Sep 2024 19:16:45 +0200
> 
> A few update suggestions were taken into account
> from static source code analysis.

Hello Markus,

In my opinion, the suggested changes aren't bringing any improvement, not
in readability nor performance ... nor anything else, really.

For how I see it, the code is fine as it is, but then, that all boils down
to code style preferences and nothing else.

Cheers,
angelo

> 
> Markus Elfring (2):
>    Avoid duplicate sg_free_table(sgt) call
>    Use common error handling code
> 
>   drivers/gpu/drm/mediatek/mtk_gem.c | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
> 
> --
> 2.46.0
>