linux-kernel - Re: [PATCH v4 34/35] bloblist: Fix use of uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLszTjQNpb+PjSkVKLrfvpaLFUP8t0k5j9L9DPGru7brcJBLg@mail.gmail.com>
Date: Thu, 19 Sep 2024 16:10:08 +0200
From: Simon Glass <sjg@...omium.org>
To: Patrick Rudolph <patrick.rudolph@...ements.com>
Cc: u-boot@...ts.denx.de, linux-kernel@...r.kernel.org, 
	Tom Rini <trini@...sulko.com>
Subject: Re: [PATCH v4 34/35] bloblist: Fix use of uninitialized variable

On Wed, 18 Sept 2024 at 17:28, Patrick Rudolph
<patrick.rudolph@...ements.com> wrote:
>
> Initialize addr to zero which allows to build on the CI
> which is more strict.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
> ---
>  common/bloblist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@...omium.org>

New patch, I believe


> diff --git a/common/bloblist.c b/common/bloblist.c
> index 2008ab4d25..cf1a3b8b62 100644
> --- a/common/bloblist.c
> +++ b/common/bloblist.c
> @@ -499,7 +499,7 @@ int bloblist_init(void)
>  {
>         bool fixed = IS_ENABLED(CONFIG_BLOBLIST_FIXED);
>         int ret = -ENOENT;
> -       ulong addr, size;
> +       ulong addr = 0, size;
>         /*
>          * If U-Boot is not in the first phase, an existing bloblist must be
>          * at a fixed address.
> --
> 2.46.0
>