linux-kernel - Re: [PATCH v4 2/2] selftests/resctrl: Adjust SNC support messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <u76ht247rzdgepo4nzuxpnhsen5wndziszus4xag7fze6cdwlu@vbmksm3nzoor>
Date: Thu, 19 Sep 2024 16:42:36 +0200
From: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
To: Reinette Chatre <reinette.chatre@...el.com>
CC: <fenghua.yu@...el.com>, <shuah@...nel.org>,
	<linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<ilpo.jarvinen@...ux.intel.com>, <tony.luck@...el.com>
Subject: Re: [PATCH v4 2/2] selftests/resctrl: Adjust SNC support messages

On 2024-09-17 at 08:32:11 -0700, Reinette Chatre wrote:
>Hi Maciej,
>
>On 8/27/24 1:15 AM, Maciej Wieczor-Retman wrote:
>> On 2024-08-12 at 16:40:10 -0700, Reinette Chatre wrote:
>> > On 7/12/24 2:04 AM, Maciej Wieczor-Retman wrote:
>
>> > > +
>> > > +	if ((get_vendor() == ARCH_INTEL) && snc_unreliable) {
>> > > +		ksft_print_msg("Sub-NUMA Clustering could not be detected properly (see earlier messages for details).\n");
>> > > +		ksft_print_msg("Intel CAT may be inaccurate.\n");
>> > > +	}
>> > 
>> > This is still relevant but unclear why previous message checked "ret" but above does not.
>> 
>> The above check tries to explain why a failure happened.
>> 
>> This check is a reminder about a false positive - the test passes but
>> "snc_unreliable" was set. I guess we could make this check to test "!ret"?
>
>Thinking about this more ... if the test results cannot be trusted at all (whether tests pass or
>fail) when snc_reliable is true then it seems more appropriate to just skip these tests when
>SNC detection is unreliable.

Okay, I'll just skip the test if the snc_unreliable is true.


-- 
Kind regards
Maciej Wieczór-Retman