linux-kernel - Re: [PATCH 00/14] staging: vt6655: Tidy up s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51-n2bqKybKvd7B3wXyKmqbcPe6_OX9KQWYmJ2N1o4PCdcFnVSbxrD9nSWombi2U-RMz6d2mRzvgAm8cVcHKQqZOxq_cs6QpHamI3UadBjU=@protonmail.com>
Date: Thu, 19 Sep 2024 14:49:28 +0000
From: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/14] staging: vt6655: Tidy up s_uGetDataDuration function

Hi Philipp,

On Wednesday, September 18th, 2024 at 23:08, Philipp Hortmann <philipp.g.hortmann@...il.com> wrote:
<cut>
> 
> Hi Dominik,
> 
> now you have put quit some afford into this patch series. Thank you.
> 
> If we change the camel case variables this way we need thousands of
> patches to fix this driver. Therefore we typically change always one
> variable for the entire driver and not for one function.

Thank you for the insight. Indeed, this way of changing variables can
result in high number of patches in the long run. I can either rework
this series in order to clean up the variables in driver scope instead of
function scope, or apply it in future contributions.

> 
> The following is just my personal opinion:
> You can keep working on this driver and your patches will remain in the
> git. But I think I will propose to delete this driver. Reason is that it
> supports maximum 54MBit/s and the connection is always weak. Its form
> factor is mini PCI that is really old. I use an adapter from mini PCI to
> PCI to get it into my Desktop PC. It furthermore is not buyable anymore.

Oh, I see. I was not aware of the fact it is not buyable anymore.

Can I ask to be added to CC in your proposition? It is a discussion
I would like to follow.

> 
> I like to focus on the hardware that is really well useable and on the
> market available:
> 
> rtl8192e
> 150MBit/s -> 12,5MByte/s real steady transfer.
> 
> buyable for some bugs as miniPCIe Card.
> 
> 
> rtl8723bs
> 150MBit/s -> >3MByte/s can be reached with the Notebook:
> 
> Odys Trendbook Next 14
> (Fedora with xfce) (I would prefer the one with 4GB RAM but I have only 2GB)
> buyable for not to much money.
> We can catch this devices because they run on Windows 10 which will not
> be supported after fall 2025
> The Driver has 146 Files with 70000 Lines. I think we can remove a lot
> because the bluetooth part is not used anymore...

Thank you for your suggestion, I will look into them.


Thanks,

Dominik Karol

> 
> There are more device drivers which need our attention...
> 
> Thanks
> 
> Bye Philipp