linux-kernel - Re: [PATCH RFC 1/6] block: Rework bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbe3c6f0-cc84-4e92-bae4-5433ee0549e2@wdc.com>
Date: Thu, 19 Sep 2024 15:50:08 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: John Garry <john.g.garry@...cle.com>, "axboe@...nel.dk" <axboe@...nel.dk>,
	hch <hch@....de>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: [PATCH RFC 1/6] block: Rework bio_split() return value

On 19.09.24 11:25, John Garry wrote:
> -	BUG_ON(sectors <= 0);
> -	BUG_ON(sectors >= bio_sectors(bio));
> +	if (WARN_ON(sectors <= 0))
> +		return ERR_PTR(-EINVAL);
> +	if (WARN_ON(sectors >= bio_sectors(bio)))
> +		return ERR_PTR(-EINVAL);

Nit: WARN_ON_ONCE() otherwise it'll trigger endless amounts of 
stacktraces in dmesg.