linux-kernel - Re: [PATCH] ath11k: modify null check logic in ath11k_ce_rx_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172676437762.281449.1201751345434084726.kvalo@kernel.org>
Date: Thu, 19 Sep 2024 16:46:19 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Mikhail Lobanov <m.lobanov@...alinux.ru>
Cc: Mikhail Lobanov <m.lobanov@...alinux.ru>,
 Jeff Johnson <jjohnson@...nel.org>,
 Govindaraj Saminathan <quic_gsamin@...cinc.com>,
 Miles Hu <milehu@...eaurora.org>, Sven Eckelmann <seckelmann@...to.com>,
 Rajkumar Manoharan <rmanohar@...eaurora.org>,
 John Crispin <john@...ozen.org>, linux-wireless@...r.kernel.org,
 ath11k@...ts.infradead.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH] ath11k: modify null check logic in
 ath11k_ce_rx_post_pipe()

Mikhail Lobanov <m.lobanov@...alinux.ru> wrote:

> The previous logic in ath11k_ce_rx_post_pipe() incorrectly required both 
> dest_ring and status_ring to be NULL in order to exit the function. 
> This caused the function to continue even if only one of the pointers 
> was NULL, potentially leading to null pointer dereferences in 
> ath11k_ce_rx_buf_enqueue_pipe().
> 
> Fix the condition by modifying the logic so that the function returns 
> early if either dest_ring or status_ring is NULL.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Mikhail Lobanov <m.lobanov@...alinux.ru>

Jeff, what do you think?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240909150824.28195-1-m.lobanov@rosalinux.ru/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html