lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0c768bf6-bc19-43de-a30b-ff5e3ddfd0b3@suse.de>
Date: Thu, 19 Sep 2024 20:58:03 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: WangYuli <wangyuli@...ontech.com>, alexander.deucher@....com,
 christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com,
 simona@...ll.ch, sunil.khatri@....com, vitaly.prosyak@....com,
 yifan1.zhang@....com, Tim.Huang@....com, jesse.zhang@....com,
 Prike.Liang@....com, Hawking.Zhang@....com, kevinyang.wang@....com,
 srinivasan.shanmugam@....com, Jiadong.Zhu@....com, tao.zhou1@....com,
 pavel@....cz, lee@...nel.org, aren@...cevolution.org
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org, le.ma@....com,
 Wenhui.Sheng@....com, jjhiblot@...phandler.com, guanwentao@...ontech.com,
 zhanjun@...ontech.com
Subject: Re: [PATCH] treewide: Correct the typo 'acccess'

Hi

Am 19.09.24 um 20:28 schrieb WangYuli:
> There are some spelling mistakes of 'acccess' in comments which
> should be instead of 'access'.
>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c   | 2 +-
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c  | 2 +-
>   drivers/leds/rgb/leds-group-multicolor.c | 2 +-

I think it's better to make 2 patches: one for amdgpu and one for leds. 
Each patch can then go into the correct tree.

If you make 2 patches, you can add

Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

to each of them.

Best regards
Thomas

>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index d3e8be82a172..f847a9fc61e1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -1894,7 +1894,7 @@ static void gfx_v11_0_init_compute_vmid(struct amdgpu_device *adev)
>   	mutex_unlock(&adev->srbm_mutex);
>   
>   	/* Initialize all compute VMIDs to have no GDS, GWS, or OA
> -	   acccess. These should be enabled by FW for target VMIDs. */
> +	   access. These should be enabled by FW for target VMIDs. */
>   	for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) {
>   		WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_BASE, 2 * i, 0);
>   		WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_SIZE, 2 * i, 0);
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index 408e5600bb61..13dca7377f53 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -1248,7 +1248,7 @@ static void gfx_v9_4_3_xcc_init_compute_vmid(struct amdgpu_device *adev,
>   	mutex_unlock(&adev->srbm_mutex);
>   
>   	/* Initialize all compute VMIDs to have no GDS, GWS, or OA
> -	   acccess. These should be enabled by FW for target VMIDs. */
> +	   access. These should be enabled by FW for target VMIDs. */
>   	for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) {
>   		WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_BASE, 2 * i, 0);
>   		WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_SIZE, 2 * i, 0);
> diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c
> index b6c7679015fd..548c7dd63ba1 100644
> --- a/drivers/leds/rgb/leds-group-multicolor.c
> +++ b/drivers/leds/rgb/leds-group-multicolor.c
> @@ -55,7 +55,7 @@ static void restore_sysfs_write_access(void *data)
>   {
>   	struct led_classdev *led_cdev = data;
>   
> -	/* Restore the write acccess to the LED */
> +	/* Restore the write access to the LED */
>   	mutex_lock(&led_cdev->led_access);
>   	led_sysfs_enable(led_cdev);
>   	mutex_unlock(&led_cdev->led_access);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ