linux-kernel - Re: [RFC PATCH net-next 4/7] net: ip: make fib_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxym3Z-5rEinjiFVhnQuKKa8AhDJ+KuiYw=9RMkKg3FgRmSEQ@mail.gmail.com>
Date: Fri, 20 Sep 2024 14:25:12 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Antoine Tenart <atenart@...nel.org>
Cc: edumazet@...gle.com, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, dsahern@...nel.org, steffen.klassert@...unet.com, 
	herbert@...dor.apana.org.au, dongml2@...natelecom.cn, bigeasy@...utronix.de, 
	toke@...hat.com, idosch@...dia.com, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [RFC PATCH net-next 4/7] net: ip: make fib_validate_source()
 return drop reason

On Thu, Sep 19, 2024 at 10:43 PM Antoine Tenart <atenart@...nel.org> wrote:
>
> Quoting Menglong Dong (2024-09-19 11:41:44)
> >
> > @@ -2339,8 +2345,11 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
> >         if (!ipv4_is_zeronet(saddr)) {
> >                 err = fib_validate_source(skb, saddr, 0, tos, 0, dev,
> >                                           in_dev, &itag);
> > -               if (err < 0)
> > +               if (err < 0) {
> > +                       err = -EINVAL;
> > +                       __reason = -err;
>
> That should be:
>
>     __reason = -err;
>     err = -EINVAL;

Oops, my mistake!

>
>
> Also this patch should take care of the fib_validate_source call in
> ip_mc_validate_source.

Yeah, I should do the same thing in ip_mc_validate_source().

Thanks!