linux-kernel - Re: [PATCH] drm/amdgpu: Fix typo "acccess" and improve the comment style here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ade271e8-2f6e-494b-979a-e53942b6b9a7@amd.com>
Date: Fri, 20 Sep 2024 08:28:49 +0200
From: Christian König <christian.koenig@....com>
To: WangYuli <wangyuli@...ontech.com>, alexander.deucher@....com,
 Xinhui.Pan@....com, airlied@...il.com, simona@...ll.ch,
 sunil.khatri@....com, yifan1.zhang@....com, vitaly.prosyak@....com,
 Tim.Huang@....com, Prike.Liang@....com, jesse.zhang@....com,
 lijo.lazar@....com, Hawking.Zhang@....com, kevinyang.wang@....com,
 srinivasan.shanmugam@....com, victorchengchi.lu@....com,
 Jiadong.Zhu@....com, tao.zhou1@....com
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, le.ma@....com, Wenhui.Sheng@....com,
 alexdeucher@...il.com, Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH] drm/amdgpu: Fix typo "acccess" and improve the comment
 style here

Am 20.09.24 um 04:27 schrieb WangYuli:
> There are some spelling mistakes of 'acccess' in comments which
> should be instead of 'access'.
>
> And the comment style should be like this:
>   /*
>    * Text
>    * Text
>    */
>
> Suggested-by: Christian König <christian.koenig@....com>
> Link: https://lore.kernel.org/all/f75fbe30-528e-404f-97e4-854d27d7a401@amd.com/
> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>
> Link: https://lore.kernel.org/all/0c768bf6-bc19-43de-a30b-ff5e3ddfd0b3@suse.de/
> Signed-off-by: WangYuli <wangyuli@...ontech.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c  | 6 ++++--
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 6 ++++--
>   2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index d3e8be82a172..33fd2da49a2a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -1893,8 +1893,10 @@ static void gfx_v11_0_init_compute_vmid(struct amdgpu_device *adev)
>   	soc21_grbm_select(adev, 0, 0, 0, 0);
>   	mutex_unlock(&adev->srbm_mutex);
>   
> -	/* Initialize all compute VMIDs to have no GDS, GWS, or OA
> -	   acccess. These should be enabled by FW for target VMIDs. */
> +	/*
> +	 * Initialize all compute VMIDs to have no GDS, GWS, or OA
> +	 * access. These should be enabled by FW for target VMIDs.
> +	 */
>   	for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) {
>   		WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_BASE, 2 * i, 0);
>   		WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_SIZE, 2 * i, 0);
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index 408e5600bb61..57b55b6d797d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -1247,8 +1247,10 @@ static void gfx_v9_4_3_xcc_init_compute_vmid(struct amdgpu_device *adev,
>   	soc15_grbm_select(adev, 0, 0, 0, 0, GET_INST(GC, xcc_id));
>   	mutex_unlock(&adev->srbm_mutex);
>   
> -	/* Initialize all compute VMIDs to have no GDS, GWS, or OA
> -	   acccess. These should be enabled by FW for target VMIDs. */
> +	/*
> +	 * Initialize all compute VMIDs to have no GDS, GWS, or OA
> +	 * access. These should be enabled by FW for target VMIDs.
> +	 */
>   	for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) {
>   		WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_BASE, 2 * i, 0);
>   		WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_SIZE, 2 * i, 0);