linux-kernel - Re: [PATCH] ice: Use common error handling code in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58d38533-bccd-4e0e-8c7a-4f7a122ce0d1@intel.com>
Date: Fri, 20 Sep 2024 08:34:46 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Markus Elfring <Markus.Elfring@....de>
CC: LKML <linux-kernel@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jacob Keller <jacob.e.keller@...el.com>,
	Jakub Kicinski <kuba@...nel.org>, Karol Kolacinski
	<karol.kolacinski@...el.com>, Paolo Abeni <pabeni@...hat.com>, "Richard
 Cochran" <richardcochran@...il.com>, Tony Nguyen <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH] ice: Use common error handling code in two functions

On 9/19/24 19:15, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 19 Sep 2024 19:00:25 +0200
> 
> Add jump targets so that a bit of exception handling can be better reused
> at the end of two function implementations.

Thank you for contribution, the change is fine, but not as a bugfix.
Please send as a [iwl-next], when the submission window opens.

> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>


> @@ -3168,6 +3164,10 @@ static int ice_ptp_init_owner(struct ice_pf *pf)
>   	pf->ptp.clock = NULL;
>   err_exit:
>   	return err;
> +
> +err_unlock:
> +	ice_ptp_unlock(hw);
> +	return err;
>   }

You kept the current label naming scheme, that's good.