linux-kernel - Re: [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF12kFtLZL_oLP8Fds_QYmC_yazGzbFH4OVOxvjH=yFHJMoHyg@mail.gmail.com>
Date: Fri, 20 Sep 2024 15:00:49 +0800
From: Cixi Geng <gengcixi@...il.com>
To: Chunyan Zhang <zhang.lyra@...il.com>, cixi.geng@...ux.dev
Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>, Enlin Mu <enlin.mu@...look.com>, 
	daniel.lezcano@...aro.org, tglx@...utronix.de, orsonzhai@...il.com, 
	linux-kernel@...r.kernel.org, enlin.mu@...soc.com, enlinmu@...il.com, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64

Chunyan Zhang <zhang.lyra@...il.com> 于2024年9月20日周五 09:48写道：
>
> On Thu, 19 Sept 2024 at 15:51, Baolin Wang
> <baolin.wang@...ux.alibaba.com> wrote:
> >
> >
> >
> > On 2024/9/19 15:25, Enlin Mu wrote:
> > > From: Enlin Mu <enlin.mu@...soc.com>
> > >
> > > sprd timer is currently available on ARM and ARM64 based devices.
> > > Thus select it for ARM and ARM64
> > >
> > > Signed-off-by: Enlin Mu <enlin.mu@...soc.com>
> > > ---
> > >   drivers/clocksource/Kconfig | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > > index 95dd4660b5b6..296c5f664583 100644
> > > --- a/drivers/clocksource/Kconfig
> > > +++ b/drivers/clocksource/Kconfig
> > > @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER
> > >   config SPRD_TIMER
> > >       bool "Spreadtrum timer driver" if EXPERT
> > >       depends on HAS_IOMEM
> > > -     depends on (ARCH_SPRD || COMPILE_TEST)
> > > -     default ARCH_SPRD
> > > +     depends on (ARM || ARM64 || COMPILE_TEST)
> >
> > I don't understand, if this driver is available on ARM, why ARCH_SPRD is
> > not enabled on ARM architecture?
the ARCH_SPRD is not enabled on ARM by default for some other configs
will enabled at same time.
we just need the SPRD_TIMER
>
> It is probably because GKI doesn't select ARCH_SPRD.
>
>
> >
> > > +     default y
> > >       select TIMER_OF
> > >       help
> > >         Enables support for the Spreadtrum timer driver.
>