linux-kernel - RE: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OS8PR06MB7541773C1DC1CCE8E4149E3AF26C2@OS8PR06MB7541.apcprd06.prod.outlook.com>
Date: Fri, 20 Sep 2024 07:33:07 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"joel@....id.au" <joel@....id.au>, "andrew@...econstruct.com.au"
	<andrew@...econstruct.com.au>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>
Subject: RE: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700

> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700
> 
> On 19/09/2024 09:13, Ryan Chen wrote:
> >> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for
> >> AST2700
> >>
> >> On 19/09/2024 08:05, Ryan Chen wrote:
> >>>>> diff --git
> >>>>> a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> >>>>> b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> >>>>> index 86ee69c0f45b..127a357051cd 100644
> >>>>> ---
> >>>>> a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> >>>>> +++
> b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yam
> >>>>> +++ l
> >>>>> @@ -9,6 +9,8 @@ title: Aspeed System Control Unit
> >>>>>  description:
> >>>>>    The Aspeed System Control Unit manages the global behaviour of
> >>>>> the
> >>>> SoC,
> >>>>>    configuring elements such as clocks, pinmux, and reset.
> >>>>> +  In AST2700 SOC which has two soc connection, each soc have its
> >>>>> + own scu  register control, ast2700-scu0 for soc0, ast2700-scu1
> >>>>> + for
> >> soc1.
> >>>>>
> >>>>>  maintainers:
> >>>>>    - Joel Stanley <joel@....id.au> @@ -21,6 +23,8 @@ properties:
> >>>>>            - aspeed,ast2400-scu
> >>>>>            - aspeed,ast2500-scu
> >>>>>            - aspeed,ast2600-scu
> >>>>> +          - aspeed,ast2700-scu0
> >>>>> +          - aspeed,ast2700-scu1
> >>>>>        - const: syscon
> >>>>>        - const: simple-mfd
> >>>>>
> >>>>> @@ -30,10 +34,12 @@ properties:
> >>>>>    ranges: true
> >>>>>
> >>>>>    '#address-cells':
> >>>>> -    const: 1
> >>>>> +    minimum: 1
> >>>>> +    maximum: 2
> >>>>>
> >>>>>    '#size-cells':
> >>>>> -    const: 1
> >>>>> +    minimum: 1
> >>>>> +    maximum: 2
> >>>>
> >>>> Why do the children have 64 bit addressing?
> >>>
> >>> AST2700 is 64bit address, so it also.
> >>
> >> But why do they need it?
> >>
> > Sorry, I may not understand your point.
> 
> I asked why do you think children require 64-bit addressing, instead of working
> with existing 32-bit address.
> 
> > Since address-cell = <2>, Do you mean size-cell still 1?
> 
> No... although that's another point, how bug address size is there? For the
> children?
> 
> > If yes. I do the dts check it need size-cells=<2>, when I do
> > address-cells = <2>
> 
> Well, I talk about bus and children addressing. It's kind of obvious that
> changing one property means using different reg...
> 
Understood your point, I don’t use so much for size, size-cell = <1> is enough, will keep <1>
> Best regards,
> Krzysztof