linux-kernel - Re: [PATCH] mm: Move set_pxd_safe() helpers from generic to platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2924c274-2b01-4b33-87e7-5b66aceba3b0@intel.com>
Date: Fri, 20 Sep 2024 01:52:34 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Anshuman Khandual <anshuman.khandual@....com>, linux-mm@...ck.org,
 akpm@...ux-foundation.org
Cc: Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Thomas Gleixner <tglx@...utronix.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 David Hildenbrand <david@...hat.com>, Ryan Roberts <ryan.roberts@....com>,
 x86@...nel.org, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Move set_pxd_safe() helpers from generic to platform

On 9/19/24 23:42, Anshuman Khandual wrote:
>> I just did a quick grep and don't see any difference between the _safe
>> and normal variants.  A quick grep didn't turn up any actual users.
>>
>> Did anyone actually double check that these are still needed on x86 in
>> the first place?
> arch/x86/mm/init_64.c

Ahh, the #defines make them immune to grep. :)

Long-term, we should make sure these are still necessary.  Short term
(in this patch), please just put the #defines in init_64.c if it is the
only site that needs them.