linux-kernel - Re: [PATCH v1] wifi: rt2x00: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240920095448.GA20424@wp.pl>
Date: Fri, 20 Sep 2024 11:54:48 +0200
From: Stanislaw Gruszka <stf_xl@...pl>
To: Yan Zhen <yanzhen@...o.com>
Cc: kvalo@...nel.org, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] wifi: rt2x00: convert comma to semicolon

On Fri, Sep 20, 2024 at 10:59:17AM +0800, Yan Zhen wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
> 
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
Acked-by: Stanislaw Gruszka <stf_xl@...pl>
> ---
>  drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index 3bb81bcff0ac..60c2a12e9d5e 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -3607,7 +3607,7 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,
>  			rt2800_rfcsr_write(rt2x00dev, 52, 0x0C);
>  			rt2800_rfcsr_write(rt2x00dev, 54, 0xF8);
>  			if (rf->channel <= 50) {
> -				rt2800_rfcsr_write(rt2x00dev, 55, 0x06),
> +				rt2800_rfcsr_write(rt2x00dev, 55, 0x06);
>  				rt2800_rfcsr_write(rt2x00dev, 56, 0xD3);
>  			} else if (rf->channel >= 52) {
>  				rt2800_rfcsr_write(rt2x00dev, 55, 0x04);
> -- 
> 2.34.1
>