linux-kernel - Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dce6b8b3-2171-47a9-b110-89ad02021fc7@kernel.org>
Date: Fri, 20 Sep 2024 13:19:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yunhong Jiang <yunhong.jiang@...ux.intel.com>
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, kys@...rosoft.com,
 haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
 rafael@...nel.org, lenb@...nel.org, kirill.shutemov@...ux.intel.com,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-hyperv@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup
 mailbox

On 20/09/2024 00:15, Yunhong Jiang wrote:
>>>
>>>>
>>>> For your "validated by the tools", can you please share the tools you used to
>>>> validate the schema? I used "make dt_binding_check" per the
>>>> submitting-patches.rst but I think your comments is about another tool.
>>>
>>> See writing-schema document.
>> Yes, I figured out in the end that the validate tools means the dt-schema tools.
>>
>> Thank you
>> --jyh
> 
> One thing just come to my mind. The
> Documentation/devicetree/bindings/x86/wakeup.yaml only adds one property,
> wakeup-mailbox-addr, to the cpus node, and it does not specify any new object.
> Per my understanding, the json schema file normally specifies a new object.
> Is my change a supported scenario in current Documentation/devicetree?

I think that's not related. You can add properties per specific devices,
but (as I said) you do not have a compatible. Compatible represents a
specific device. You do not have it. Look at the cpus.yaml schema.

> 
> I checked similar scenario like arm/cpu-enable-method/nuvoton and
> npcm750-smp/cpu-enable-method/al,alpine-smp, they don't present as a json
> schema file. Wonder if it's because the same reason.

Rather no one cares about that hardware.


Best regards,
Krzysztof