linux-kernel - Re: [PATCH v15 00/19] tracing: fprobe: function_graph: Multi-function graph and fprobe on fgraph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240920132659.48d4563d4ab4ff32ba64d65a@kernel.org>
Date: Fri, 20 Sep 2024 13:26:59 +0200
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Steven Rostedt
 <rostedt@...dmis.org>, Florent Revest <revest@...omium.org>,
 linux-trace-kernel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, bpf <bpf@...r.kernel.org>, Sven
 Schnelle <svens@...ux.ibm.com>, Alexei Starovoitov <ast@...nel.org>, Jiri
 Olsa <jolsa@...nel.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Alan Maguire <alan.maguire@...cle.com>,
 Mark Rutland <mark.rutland@....com>, Peter Zijlstra <peterz@...radead.org>,
 Thomas Gleixner <tglx@...utronix.de>, Guo Ren <guoren@...nel.org>,
 linux-arch@...r.kernel.org
Subject: Re: [PATCH v15 00/19] tracing: fprobe: function_graph:
 Multi-function graph and fprobe on fgraph

On Wed, 18 Sep 2024 23:22:41 +0200
Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:

> On Sun, Sep 15, 2024 at 11:09 AM Masami Hiramatsu (Google)
> <mhiramat@...nel.org> wrote:
> >
> > Hi,
> >
> > Here is the 15th version of the series to re-implement the fprobe on
> > function-graph tracer. The previous version is;
> >
> > https://lore.kernel.org/all/172615368656.133222.2336770908714920670.stgit@devnote2/
> >
> > This version rebased on Steve's calltime change[1] instead of the last
> > patch in the previous series, and adds a bpf patch to add get_entry_ip()
> > for arm64. Note that [1] is not included in this series, so please use
> > the git branch[2].
> >
> 
> With LPC and Kernel Recipes back-to-back I won't have time to look
> through the code, but I did manage to run some benchmarks tonight, and
> they look pretty good now, thanks! Seems like the kprobe regression is
> gone, and kretprobes are a bit faster. So, nice work, thanks!
> 
> BEFORE
> ======
> kprobe         :   25.052 ± 0.032M/s
> kprobe-multi   :   28.102 ± 0.167M/s
> kretprobe      :   10.724 ± 0.008M/s
> kretprobe-multi:   11.337 ± 0.054M/s
> 
> AFTER
> =====
> kprobe         :   25.206 ± 0.026M/s
> kprobe-multi   :   30.167 ± 0.148M/s
> kretprobe      :   10.714 ± 0.016M/s
> kretprobe-multi:   13.436 ± 0.328M/s

Thanks for reevaluate the series!
This results look nice.

Thank you,

> 
> > [1] https://lore.kernel.org/all/20240914214805.779822616@goodmis.org/
> > [2] https://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git/log/?h=topic/fprobe-on-fgraph
> >
> 
> [...]


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>