[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <D4B2W6MR4585.3IS3HYGQ6GM6O@kernel.org>
Date: Fri, 20 Sep 2024 14:35:07 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Shuai Xue" <xueshuai@...ux.alibaba.com>, <mark.rutland@....com>,
<catalin.marinas@....com>, <mingo@...hat.com>, <robin.murphy@....com>,
<Jonathan.Cameron@...wei.com>, <bp@...en8.de>, <rafael@...nel.org>,
<wangkefeng.wang@...wei.com>, <tanxiaofei@...wei.com>,
<mawupeng1@...wei.com>, <tony.luck@...el.com>, <linmiaohe@...wei.com>,
<naoya.horiguchi@....com>, <james.morse@....com>, <tongtiangen@...wei.com>,
<gregkh@...uxfoundation.org>, <will@...nel.org>
Cc: <linux-acpi@...r.kernel.org>, <linux-mm@...ck.org>,
<linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>,
<linux-edac@...r.kernel.org>, <x86@...nel.org>, <justin.he@....com>,
<ardb@...nel.org>, <ying.huang@...el.com>, <ashish.kalra@....com>,
<baolin.wang@...ux.alibaba.com>, <tglx@...utronix.de>,
<dave.hansen@...ux.intel.com>, <lenb@...nel.org>, <hpa@...or.com>,
<robert.moore@...el.com>, <lvying6@...wei.com>, <xiexiuqi@...wei.com>,
<zhuo.song@...ux.alibaba.com>
Subject: Re: [PATCH v13 1/3] ACPI: APEI: send SIGBUS to current task if
synchronous memory error not recovered
On Fri Sep 20, 2024 at 7:30 AM EEST, Shuai Xue wrote:
> Synchronous error was detected as a result of user-space process accessing
> a 2-bit uncorrected error. The CPU will take a synchronous error exception
> such as Synchronous External Abort (SEA) on Arm64. The kernel will queue a
> memory_failure() work which poisons the related page, unmaps the page, and
> then sends a SIGBUS to the process, so that a system wide panic can be
> avoided.
>
> However, no memory_failure() work will be queued when abnormal synchronous
> errors occur. These errors can include situations such as invalid PA,
> unexpected severity, no memory failure config support, invalid GUID
> section, etc. In such case, the user-space process will trigger SEA again.
> This loop can potentially exceed the platform firmware threshold or even
> trigger a kernel hard lockup, leading to a system reboot.
>
> Fix it by performing a force kill if no memory_failure() work is queued
> for synchronous errors.
>
> Signed-off-by: Shuai Xue <xueshuai@...ux.alibaba.com>
> ---
> drivers/acpi/apei/ghes.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 623cc0cb4a65..93eb11482832 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -801,6 +801,16 @@ static bool ghes_do_proc(struct ghes *ghes,
> }
> }
>
> + /*
> + * If no memory failure work is queued for abnormal synchronous
> + * errors, do a force kill.
> + */
> + if (sync && !queued) {
> + pr_err("%s:%d: hardware memory corruption (SIGBUS)\n",
> + current->comm, task_pid_nr(current));
> + force_sig(SIGBUS);
> + }
> +
> return queued;
> }
>
Looks good to me!
Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
BR, Jarkko
Powered by blists - more mailing lists