linux-kernel - Re: [PATCH v2] clk: samsung: fsd: Mark PLL_CAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04ad8ea5-2c76-4007-b9ad-87b935072b8b@kernel.org>
Date: Fri, 20 Sep 2024 14:43:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Inbaraj E <inbaraj.e@...sung.com>, s.nawrocki@...sung.com,
 cw00.choi@...sung.com, alim.akhtar@...sung.com, mturquette@...libre.com,
 sboyd@...nel.org, linux-samsung-soc@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: pankaj.dubey@...sung.com, gost.dev@...sung.com
Subject: Re: [PATCH v2] clk: samsung: fsd: Mark PLL_CAM_CSI as critical

On 19/09/2024 14:39, Inbaraj E wrote:
> PLL_CAM_CSI is the parent clock for the ACLK and PCLK in the CMU_CAM_CSI
> block. When we gate ACLK or PCLK, the clock framework will subsequently
> disables the parent clocks(PLL_CAM_CSI). Disabling PLL_CAM_CSI is causing
> system level halt.
> 
> It was observed on FSD SoC, when we gate the ACLK and PCLK during CSI stop
> streaming through pm_runtime_put system is getting halted. So marking
> PLL_CAM_CSI as critical to prevent disabling.

No, please do not send new versions while discussion is going.

See my replies in previous version.

Also, if this stays, then you miss Cc-stable.

Best regards,
Krzysztof