linux-kernel - Re: [PATCH v2] platform/x86/intel/pmt: Correct the typo 'ACCCESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10db0939-a273-7a84-dcc9-c9b70ff7cc64@linux.intel.com>
Date: Fri, 20 Sep 2024 17:14:42 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: WangYuli <wangyuli@...ontech.com>
cc: david.e.box@...ux.intel.com, Hans de Goede <hdegoede@...hat.com>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    tzimmermann@...e.de, lee.jones@...aro.org, lee@...nel.org, 
    guanwentao@...ontech.com, zhanjun@...ontech.com
Subject: Re: [PATCH v2] platform/x86/intel/pmt: Correct the typo
 'ACCCESS_LOCAL'

On Fri, 20 Sep 2024, WangYuli wrote:

> There is a spelling mistake of 'ACCCESS_LOCAL' which should be
> 'ACCESS_LOCAL'.
> 
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Did I actually suggest the change this patch makes somewhere? I recall 
noting the typo at one point myself but I don't remember telling anyone 
about it.

Reviewing your patch does not itself count as a reason for adding 
Suggested-by (unless the entire approach used in the patch is changed 
because of a reviewer comment which is not the case here).

-- 
 i.

> Link: https://lore.kernel.org/all/26b8f38f-ff32-81fb-bbe5-aa141239427e@linux.intel.com/
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  drivers/platform/x86/intel/pmt/class.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c
> index c04bb7f97a4d..7680474c4f96 100644
> --- a/drivers/platform/x86/intel/pmt/class.c
> +++ b/drivers/platform/x86/intel/pmt/class.c
> @@ -207,7 +207,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
>  		/*
>  		 * Some hardware use a different calculation for the base address
>  		 * when access_type == ACCESS_LOCAL. On the these systems
> -		 * ACCCESS_LOCAL refers to an address in the same BAR as the
> +		 * ACCESS_LOCAL refers to an address in the same BAR as the
>  		 * header but at a fixed offset. But as the header address was
>  		 * supplied to the driver, we don't know which BAR it was in.
>  		 * So search for the bar whose range includes the header address.
>