linux-kernel - Re: [PATCH v4 4/6] i2c: npcm: Modify the client address assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zu2HmkagbpMf_CNE@smile.fi.intel.com>
Date: Fri, 20 Sep 2024 17:32:58 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: warp5tw@...il.com
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
	andi.shyti@...nel.org, wsa@...nel.org, rand.sec96@...il.com,
	wsa+renesas@...g-engineering.com, tali.perry@...oton.com,
	Avi.Fishman@...oton.com, tomer.maimon@...oton.com,
	KWLIU@...oton.com, JJLIU0@...oton.com, kfting@...oton.com,
	openbmc@...ts.ozlabs.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/6] i2c: npcm: Modify the client address assignment

On Fri, Sep 20, 2024 at 06:18:18PM +0800, warp5tw@...il.com wrote:
> From: Tyrone Ting <kfting@...oton.com>
> 
> From: Tyrone Ting <kfting@...oton.com>

It seems all your mails have an issue.

> Store the client address earlier since it might get called in
> the i2c_recover_bus logic flow at the early stage of the func()
> npcm_i2c_master_xfer.

You got my comment really wrong.

func() in my example was to refer to _a_ function mentioned in the text.
And IIRC I even posted the example, like: i2c_recover_bus().

-- 
With Best Regards,
Andy Shevchenko