linux-kernel - Re: [PATCH V3] watchdog: xilinx_wwdt: Calculate max_hw_heartbeat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2509005b-2dbd-4dde-bd78-c832a2a343a0@roeck-us.net>
Date: Fri, 20 Sep 2024 07:58:19 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Harini T <harini.t@....com>, michal.simek@....com,
 srinivas.neeli@....com, shubhrajyoti.datta@....com
Cc: srinivas.goud@....com, wim@...ux-watchdog.org,
 linux-watchdog@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, git@....com
Subject: Re: [PATCH V3] watchdog: xilinx_wwdt: Calculate max_hw_heartbeat_ms
 using clock frequency

On 9/13/24 04:32, Harini T wrote:
> In the current implementation, the value of max_hw_heartbeat_ms is set
> to the timeout period expressed in milliseconds and fails to verify if
> the close window percentage exceeds the maximum value that the hardware
> supports.
> 
> 1. Calculate max_hw_heartbeat_ms based on input clock frequency.
> 2. Update frequency check to require a minimum frequency of 1Mhz.
> 3. Limit the close and open window percent to hardware supported value
> to avoid truncation.
> 4. If the user input timeout exceeds the maximum timeout supported, use
> only open window and the framework supports the higher timeouts.
> 
> Fixes: 12984cea1b8c ("watchdog: xilinx_wwdt: Add Versal window watchdog support")
> 
> Signed-off-by: Harini T <harini.t@....com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>