linux-kernel - Re: [PATCH] powerpc/kvm: Fix typo in the kvm functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6aagyzb.fsf@gmail.com>
Date: Fri, 20 Sep 2024 20:21:20 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: Kajol Jain <kjain@...ux.ibm.com>, mpe@...erman.id.au, atrajeev@...ux.vnet.ibm.com, maddy@...ux.ibm.com, disgoel@...ux.ibm.com, hbathini@...ux.ibm.com, adubey@...ux.ibm.com, gautam@...ux.ibm.com, linuxppc-dev@...ts.ozlabs.org
Cc: kjain@...ux.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/kvm: Fix typo in the kvm functions

Kajol Jain <kjain@...ux.ibm.com> writes:

> Fix typo in the following kvm function names from:
>
> kmvhv_counters_tracepoint_regfunc -> kvmhv_counters_tracepoint_regfunc
> kmvhv_counters_tracepoint_unregfunc -> kvmhv_counters_tracepoint_unregfunc

Gr8 spotting!
It took sometime to realize k[mv] and k[vm] is the change :) 

>
> Fixes: e1f288d2f9c6 ("KVM: PPC: Book3S HV nestedv2: Add support for reading VPA counters for pseries guests")

Right. This commit added the registration and unregistration helpers
for TRACE_EVEN_FN_COND tracepoint which mainly collects the
observability stats for nested guest on pseries.


> Reported-by: Madhavan Srinivasan <maddy@...ux.ibm.com>
> Signed-off-by: Kajol Jain <kjain@...ux.ibm.com>
> ---
>  arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++--
>  arch/powerpc/kvm/book3s_hv.c             | 4 ++--
>  arch/powerpc/kvm/trace_hv.h              | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)

Not an expert in kvm area. But the change looks very straight forward to
me. Searching for "kmv" string in arch/powerpc/ after applying this
patch indeed resulted in zero hits. 

Please feel free to add - 

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>